Fix unresolved shared library dependency on binutils 2.23.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 3875 matching lines @@
           }],
           ['linux_use_bundled_gold==1', {
             # Put our binutils, which contains gold in the search path. We pass
             # the path to gold to the compiler. gyp leaves unspecified what the
             # cwd is when running the compiler, so the normal gyp path-munging
             # fails us. This hack gets the right path.
             'ldflags': [
               '-B<!(cd <(DEPTH) && pwd -P)/<(binutils_dir)',
             ],
           }],
-          ['binutils_version>=224', {
+          ['binutils_version>=223', {

[dshwang, 2014/04/23 15:23:45]

I'm not sure if 222 works also. Anyway, 223 work well on my machine using "GNU
assembler (GNU Binutils for Ubuntu) 2.23.52.20130913"

[Lei Zhang, 2014/04/23 18:14:09]

I'm worried older 2.23 releases didn't have new-dtags enabled but newer 2.23
releases do. Maybe it's ok if they all take --disable-new-dtags.

Let me check this and get back to you.

[dshwang, 2014/04/23 20:05:23]

Thank you for review.
I think omitting --disable-new-dtags does not break old binutils, because we
don't use this flag before https://codereview.chromium.org/196573022

This flag is introduced for brand-new binutils in thirdparty/binutils
I don't think anyone use binutil 2.24 before the CL.

[dshwang, 2014/04/23 20:14:53]

Ah, my previous comment does not make sense.

The core of concern is that this CL try to introduce --disable-new-dtags in
binutils 2.23.
I could not check it yet because googling binutils shows me a lot of wastes.

             # Newer binutils don't set DT_RPATH unless you disable "new" dtags
             # and the new DT_RUNPATH doesn't work without --no-as-needed flag.
             # FIXME(mithro): Figure out the --as-needed/--no-as-needed flags
             # inside this file to allow usage of --no-as-needed and removal of
             # this flag.
             'ldflags': [
               '-Wl,--disable-new-dtags',
             ],
           }]
         ],
@@ skipping 1313 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }