Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2490563002: Revert of DevTools: add the logging aspect into the PerformanceMonitor (Closed)

Created:
4 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
4 years, 1 month ago
Reviewers:
panicker, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: add the logging aspect into the PerformanceMonitor (patchset #6 id:100001 of https://codereview.chromium.org/2474073005/ ) Reason for revert: Speculative revert as sheriff since we see a failure in WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization on Win10. See link below for details: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/5799/steps/browser_tests%20on%20Windows-10-10586/logs/WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization Original issue's description: > DevTools: add the logging aspect into the PerformanceMonitor, plumb it over the remote debugging protocol, surface it in DevTools. Also adds proof of concept violation reporting for layout thrashing and long running tasks. > > BUG=662497 > > Committed: https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f > Cr-Commit-Position: refs/heads/master@{#430418} TBR=panicker@chromium.org,dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -323 lines) Patch
M content/browser/devtools/protocol/page_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/input-event-warning.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 4 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.h View 5 chunks +2 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp View 6 chunks +27 lines, -169 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleTypes.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLogAgent.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp View 6 chunks +2 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 3 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 5 chunks +4 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
henrika (OOO until Aug 14)
Created Revert of DevTools: add the logging aspect into the PerformanceMonitor
4 years, 1 month ago (2016-11-08 12:07:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490563002/1
4 years, 1 month ago (2016-11-08 12:08:06 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 12:08:58 UTC) #5
Failed to apply patch for
third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:69
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp' with
conflicts.
  U third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Patch:      
third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
diff --git
a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
index
ed4e3ee586ad526cab5b7f884d0ea0af6b7f0d5b..1d4dbda772ab9ed214f5c6f7e74b3394b8dd1624
100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
@@ -69,8 +69,7 @@
   m_session = new InspectorSession(this, m_instrumentingAgents.get(), 0,
                                    m_debugger->v8Inspector(),
                                    m_debugger->contextGroupId(), nullptr);
-  m_session->append(
-      new InspectorLogAgent(m_thread->consoleMessageStorage(), nullptr));
+  m_session->append(new InspectorLogAgent(m_thread->consoleMessageStorage()));
   m_thread->workerBackingThread().backingThread().addTaskObserver(this);
 }

Powered by Google App Engine
This is Rietveld 408576698