Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2490563002: Revert of DevTools: add the logging aspect into the PerformanceMonitor (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index dda60e39a0448e4d117aa92a5c5b9ea2bc3cf182..781209df993fc52c92894440133eb93d773a0e10 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -191,7 +191,6 @@
*/
_buildMessage(consoleMessage) {
var messageElement;
- var messageText = consoleMessage.messageText;
if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.ConsoleAPI) {
switch (consoleMessage.type) {
case WebInspector.ConsoleMessage.MessageType.Trace:
@@ -214,13 +213,13 @@
break;
case WebInspector.ConsoleMessage.MessageType.Profile:
case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
- messageElement = this._format([messageText]);
+ messageElement = this._format([consoleMessage.messageText]);
break;
default:
if (consoleMessage.parameters && consoleMessage.parameters.length === 1 &&
consoleMessage.parameters[0].type === 'string')
messageElement = this._tryFormatAsError(/** @type {string} */ (consoleMessage.parameters[0].value));
- var args = consoleMessage.parameters || [messageText];
+ var args = consoleMessage.parameters || [consoleMessage.messageText];
messageElement = messageElement || this._format(args);
}
} else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
@@ -238,16 +237,14 @@
' ', String(consoleMessage.request.statusCode), ' (', consoleMessage.request.statusText, ')');
} else {
var fragment = WebInspector.linkifyStringAsFragmentWithCustomLinkifier(
- messageText, linkifyRequest.bind(consoleMessage));
+ consoleMessage.messageText, linkifyRequest.bind(consoleMessage));
messageElement.appendChild(fragment);
}
} else {
- messageElement = this._format([messageText]);
+ messageElement = this._format([consoleMessage.messageText]);
}
} else {
- if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Violation)
- messageText = WebInspector.UIString('[Violation] %s', messageText);
- var args = consoleMessage.parameters || [messageText];
+ var args = consoleMessage.parameters || [consoleMessage.messageText];
messageElement = this._format(args);
}
messageElement.classList.add('console-message-text');

Powered by Google App Engine
This is Rietveld 408576698