Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2490493002: Pass the permission type to NotificationPermissionInfoBarDelegate (Closed)

Created:
4 years, 1 month ago by raymes
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-permissions_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass the permission type to NotificationPermissionInfoBarDelegate NotificationPermissionInfoBarDelegate is used for both the notifications permission and for the push messaging permission. For correctness (mainly with metrics right now), we need to pass the correct permission type through to the PermissionInfobarDelegate. BUG=644256 Committed: https://crrev.com/00d49400f8a7c4f189e132c00ed0118f606c4dc8 Cr-Commit-Position: refs/heads/master@{#430750}

Patch Set 1 #

Patch Set 2 : Pass the permission type to NotificationPermissionInfoBarDelegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/browser/notifications/notification_permission_infobar_delegate.h View 1 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_permission_infobar_delegate.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
raymes
Hi Peter - this is correcting the issue I raised in https://codereview.chromium.org/2316673002
4 years, 1 month ago (2016-11-08 06:22:43 UTC) #4
Peter Beverloo
lgtm, thanks! Looks like the only non-UMA use of the value is ShouldShowPersistenceToggle(), which isn't ...
4 years, 1 month ago (2016-11-08 14:46:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490493002/20001
4 years, 1 month ago (2016-11-08 23:10:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 23:17:33 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:38:16 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00d49400f8a7c4f189e132c00ed0118f606c4dc8
Cr-Commit-Position: refs/heads/master@{#430750}

Powered by Google App Engine
This is Rietveld 408576698