Fix PushManager.subscribe() permission request on Android

Fix PushManager.subscribe() permission request on Android

https://codereview.chromium.org/2149883002 merged the
PushMessagingPermissionContext into the NotificationPermissionContext.
Unfortunately, this meant that PushManager.subscribe() tried to show
a push messaging permission infobar instead of the notifications
infobar, which fails because there is no push messaging infobar. This
patch switches push messaging back to the notifications infobar.

BUG=644256
Committed: https://crrev.com/e0db126dd99d297686d49eedd745d196708167ee
Cr-Commit-Position: refs/heads/master@{#416762}

[johnme, 2016-09-06 15:23:54]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[harkness, 2016-09-06 15:24:05]

harkness@chromium.org changed reviewers:
+ harkness@chromium.org

[harkness, 2016-09-06 15:24:05]

lgtm but you should have someone more familiar with Java also take a look.

[commit-bot: I haz the power, 2016-09-06 15:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[johnme, 2016-09-06 15:27:35]

johnme@chromium.org changed reviewers:
+ peter@chromium.org, raymes@chromium.org

[johnme, 2016-09-06 15:27:35]

raymes: Please review changes in chrome/browser/permissions

peter: Please review changes in chrome/android

I'm hoping to land this and request merge to m54 tonight. Thanks!

[Peter Beverloo, 2016-09-06 15:28:10]

lgtm

[commit-bot: I haz the power, 2016-09-06 17:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:04:54]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-09-06 23:06:38]

lgtm

https://codereview.chromium.org/2316673002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2316673002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_queue_controller.cc:135: infobar_ =
NotificationPermissionInfoBarDelegate::Create(
This looks ok to merge to me. I think we actually need to pass in the permission
type here, because it's used in PermissionInfoBarDelegate but I don't think that
will have any impact right now (the code that uses it is behind a flag).

[raymes, 2016-09-06 23:08:00]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:08:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:16:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 23:20:01]

Description was changed from

==========
Fix PushManager.subscribe() permission request on Android

https://codereview.chromium.org/2149883002 merged the
PushMessagingPermissionContext into the NotificationPermissionContext.
Unfortunately, this meant that PushManager.subscribe() tried to show
a push messaging permission infobar instead of the notifications
infobar, which fails because there is no push messaging infobar. This
patch switches push messaging back to the notifications infobar.

BUG=644256
==========

to

==========
Fix PushManager.subscribe() permission request on Android

https://codereview.chromium.org/2149883002 merged the
PushMessagingPermissionContext into the NotificationPermissionContext.
Unfortunately, this meant that PushManager.subscribe() tried to show
a push messaging permission infobar instead of the notifications
infobar, which fails because there is no push messaging infobar. This
patch switches push messaging back to the notifications infobar.

BUG=644256

Committed: https://crrev.com/e0db126dd99d297686d49eedd745d196708167ee
Cr-Commit-Position: refs/heads/master@{#416762}
==========

[commit-bot: I haz the power, 2016-09-06 23:20:02]

Patchset 2 (id:??) landed as
https://crrev.com/e0db126dd99d297686d49eedd745d196708167ee
Cr-Commit-Position: refs/heads/master@{#416762}