Pull up equivalent image decoding tests

third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h
diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h
index d860e5087f22439af91d4acd8e156994e60371d3..3b4ae9207fa05ff06ac8c6fa3eebda36c672716a 100644
--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h
+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h
@@ -20,9 +20,58 @@ unsigned hashBitmap(const SkBitmap&);
 void createDecodingBaseline(DecoderCreator,
                             SharedBuffer*,
                             Vector<unsigned>* baselineHashes);
+
+void testByteByByteDecode(DecoderCreator createDecoder,
+                          const char* file,
+                          size_t expectedFrameCount,
+                          int expectedRepetitionCount);
 void testByteByByteDecode(DecoderCreator createDecoder,
+                          const char* dir,
                           const char* file,
                           size_t expectedFrameCount,
                           int expectedRepetitionCount);
+
 void testMergeBuffer(DecoderCreator createDecoder, const char* file);
+void testMergeBuffer(DecoderCreator createDecoder,
+                     const char* dir,
+                     const char* file);
+
+void testRandomFrameDecode(DecoderCreator,
+                           const char* file,
+                           size_t skippingStep = 5);

[scroggo_chromium, 2016/11/11 13:18:42]

I may have overlooked something, but it looks like we always use the default?
Why not remove the parameter and make this a constant inside the method? (Same
for the other three with skippingStep)

[joostouwerling, 2016/11/11 14:43:58]

As you guessed correctly, I have a different value for APNG tests :)

+void testRandomFrameDecode(DecoderCreator,
+                           const char* dir,
+                           const char* file,
+                           size_t skippingStep = 5);
+
+void testRandomDecodeAfterClearFrameBufferCache(DecoderCreator,
+                                                const char* file,
+                                                size_t skippingStep = 5);
+void testRandomDecodeAfterClearFrameBufferCache(DecoderCreator,
+                                                const char* dir,
+                                                const char* file,
+                                                size_t skippingStep = 5);
+
+void testDecodeAfterReallocatingData(DecoderCreator, const char* file);
+void testDecodeAfterReallocatingData(DecoderCreator,
+                                     const char* dir,
+                                     const char* file);
+void testByteByByteSizeAvailable(DecoderCreator,
+                                 const char* file,
+                                 size_t frameOffset,
+                                 bool hasColorSpace,
+                                 int expectedRepetitionCount);
+void testByteByByteSizeAvailable(DecoderCreator,
+                                 const char* dir,
+                                 const char* file,
+                                 size_t frameOffset,
+                                 bool hasColorSpace,
+                                 int expectedRepetitionCount);
+void testProgressiveDecoding(DecoderCreator,
+                             const char* file,
+                             size_t increment = 1);

[scroggo_chromium, 2016/11/11 13:18:42]

It also looks like we also use the default for both of these? Why not remove the
parameter?

[joostouwerling, 2016/11/11 14:43:58]

See above.

+void testProgressiveDecoding(DecoderCreator,
+                             const char* dir,
+                             const char* file,
+                             size_t increment = 1);
 }  // namespace blink