Pull up equivalent image decoding tests

third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "wtf/Vector.h"
 #include <memory>
 
 class SkBitmap;
 
 namespace blink {
 class ImageDecoder;
 class SharedBuffer;
 
 const char decodersTestingDir[] = "Source/platform/image-decoders/testing";
 
 using DecoderCreator = std::unique_ptr<ImageDecoder> (*)();
 PassRefPtr<SharedBuffer> readFile(const char* fileName);
 PassRefPtr<SharedBuffer> readFile(const char* dir, const char* fileName);
 unsigned hashBitmap(const SkBitmap&);
 void createDecodingBaseline(DecoderCreator,
                             SharedBuffer*,
                             Vector<unsigned>* baselineHashes);
+
 void testByteByByteDecode(DecoderCreator createDecoder,
                           const char* file,
                           size_t expectedFrameCount,
                           int expectedRepetitionCount);
+void testByteByByteDecode(DecoderCreator createDecoder,
+                          const char* dir,
+                          const char* file,
+                          size_t expectedFrameCount,
+                          int expectedRepetitionCount);
+
 void testMergeBuffer(DecoderCreator createDecoder, const char* file);
+void testMergeBuffer(DecoderCreator createDecoder,
+                     const char* dir,
+                     const char* file);
+
+void testRandomFrameDecode(DecoderCreator,
+                           const char* file,
+                           size_t skippingStep = 5);

[scroggo_chromium, 2016/11/11 13:18:42]

I may have overlooked something, but it looks like we always use the default?
Why not remove the parameter and make this a constant inside the method? (Same
for the other three with skippingStep)

[joostouwerling, 2016/11/11 14:43:58]

As you guessed correctly, I have a different value for APNG tests :)

+void testRandomFrameDecode(DecoderCreator,
+                           const char* dir,
+                           const char* file,
+                           size_t skippingStep = 5);
+
+void testRandomDecodeAfterClearFrameBufferCache(DecoderCreator,
+                                                const char* file,
+                                                size_t skippingStep = 5);
+void testRandomDecodeAfterClearFrameBufferCache(DecoderCreator,
+                                                const char* dir,
+                                                const char* file,
+                                                size_t skippingStep = 5);
+
+void testDecodeAfterReallocatingData(DecoderCreator, const char* file);
+void testDecodeAfterReallocatingData(DecoderCreator,
+                                     const char* dir,
+                                     const char* file);
+void testByteByByteSizeAvailable(DecoderCreator,
+                                 const char* file,
+                                 size_t frameOffset,
+                                 bool hasColorSpace,
+                                 int expectedRepetitionCount);
+void testByteByByteSizeAvailable(DecoderCreator,
+                                 const char* dir,
+                                 const char* file,
+                                 size_t frameOffset,
+                                 bool hasColorSpace,
+                                 int expectedRepetitionCount);
+void testProgressiveDecoding(DecoderCreator,
+                             const char* file,
+                             size_t increment = 1);

[scroggo_chromium, 2016/11/11 13:18:42]

It also looks like we also use the default for both of these? Why not remove the
parameter?

[joostouwerling, 2016/11/11 14:43:58]

See above.

+void testProgressiveDecoding(DecoderCreator,
+                             const char* dir,
+                             const char* file,
+                             size_t increment = 1);
 }  // namespace blink