third_party/inspector_protocol/CodeGenerator.py - Issue 2490473004: [DevTools] Roll third_party/inspector_protocol to e23134c5aa6131e5a3a3afbefce255becce3a3bd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/inspector_protocol/CodeGenerator.py

Issue 2490473004: [DevTools] Roll third_party/inspector_protocol to e23134c5aa6131e5a3a3afbefce255becce3a3bd. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/inspector_protocol/CodeGenerator.py

diff --git a/third_party/inspector_protocol/CodeGenerator.py b/third_party/inspector_protocol/CodeGenerator.py

index 18073ddc29532e9a5afc09e942d5d91122b32a95..8cc9030bdb127bf895c4271322d82a5d64cd9ab0 100644

--- a/third_party/inspector_protocol/CodeGenerator.py

+++ b/third_party/inspector_protocol/CodeGenerator.py

@@ -287,7 +287,7 @@ def wrap_array_definition(type):

"raw_type": "protocol::Array<%s>" % type["raw_type"],

"raw_pass_type": "protocol::Array<%s>*" % type["raw_type"],

"raw_return_type": "protocol::Array<%s>*" % type["raw_type"],

- "create_type": "wrapUnique(new protocol::Array<%s>())" % type["raw_type"],

+ "create_type": "protocol::Array<%s>::create()" % type["raw_type"],

kozy 2016/11/08 21:40:02 Please just remove this.

"out_type": "protocol::Array<%s>&" % type["raw_type"],

}