Replace unique_ptr.reset with std::move() in error_page/renderer

Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626
Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer

Committed: https://crrev.com/77666edc7219541b2af29981b398b2221bcb77e5
Cr-Commit-Position: refs/heads/master@{#432355}

[sanghee, 2016-11-11 00:15:54]

sanghee.lee1992@gmail.com changed reviewers:
+ juliatuttle@chromium.org

[sanghee, 2016-11-11 00:15:55]

PTAL.

[sanghee, 2016-11-11 00:16:05]

Description was changed from

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer
==========

to

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer
==========

[sanghee, 2016-11-12 02:54:34]

sanghee.lee1992@gmail.com changed reviewers:
+ mmenke@chromium.org
- juliatuttle@chromium.org

[sanghee, 2016-11-12 02:54:47]

PATL.

[mmenke, 2016-11-14 16:12:32]

If you add someone as a reviewer after your first email, please be sure to make
it clear that you're doing so.  An email with just "PTAL" can easily be
overlooked, since people tend to watch a bunch of files, any may not notice the
PTAL is addressed to them.

The first published email on a CL will include a reviewers list, but others will
not.

https://codereview.chromium.org/2490413002/diff/1/components/error_page/rende...
File components/error_page/renderer/net_error_helper_core_unittest.cc (right):

https://codereview.chromium.org/2490413002/diff/1/components/error_page/rende...
components/error_page/renderer/net_error_helper_core_unittest.cc:361:
last_error_page_params_ = std::move(params)* reload_button_shown = false;
Looks like you removed a bit more than you intended to here.

[sanghee, 2016-11-15 03:57:02]

On 2016/11/14 16:12:32, mmenke wrote:
> If you add someone as a reviewer after your first email, please be sure to
make
> it clear that you're doing so.  An email with just "PTAL" can easily be
> overlooked, since people tend to watch a bunch of files, any may not notice
the
> PTAL is addressed to them.
> 
> The first published email on a CL will include a reviewers list, but others
will
> not.
> 
>
https://codereview.chromium.org/2490413002/diff/1/components/error_page/rende...
> File components/error_page/renderer/net_error_helper_core_unittest.cc (right):
> 
>
https://codereview.chromium.org/2490413002/diff/1/components/error_page/rende...
> components/error_page/renderer/net_error_helper_core_unittest.cc:361:
> last_error_page_params_ = std::move(params)* reload_button_shown = false;
> Looks like you removed a bit more than you intended to here.

Thank you for teaching me. I will be carful later

[mmenke, 2016-11-15 16:14:28]

LGTM, thanks for the cleanup!

[sanghee, 2016-11-15 22:01:25]

The CQ bit was checked by sanghee.lee1992@gmail.com

[commit-bot: I haz the power, 2016-11-15 22:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:31:14]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sanghee, 2016-11-16 01:58:07]

The CQ bit was checked by sanghee.lee1992@gmail.com

[commit-bot: I haz the power, 2016-11-16 01:58:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:14:12]

Description was changed from

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer
==========

to

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer
==========

[commit-bot: I haz the power, 2016-11-16 02:14:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 02:25:02]

Description was changed from

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer
==========

to

==========
Replace unique_ptr.reset with std::move() in error_page/renderer

BUG=644626

Replace unique_ptr.reset(other_unique_ptr.release() with std::move()
in component/error_page/renderer

Committed: https://crrev.com/77666edc7219541b2af29981b398b2221bcb77e5
Cr-Commit-Position: refs/heads/master@{#432355}
==========

[commit-bot: I haz the power, 2016-11-16 02:25:03]

Patchset 2 (id:??) landed as
https://crrev.com/77666edc7219541b2af29981b398b2221bcb77e5
Cr-Commit-Position: refs/heads/master@{#432355}