components/error_page/renderer/net_error_helper_core.h - Issue 2490413002: Replace unique_ptr.reset with std::move() in error_page/renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.h

Issue 2490413002: Replace unique_ptr.reset with std::move() in error_page/renderer (Closed)

Patch Set: Replace unique_ptr.reset with std::move() in error_page/renderer Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/renderer/net_error_helper_core.h

diff --git a/components/error_page/renderer/net_error_helper_core.h b/components/error_page/renderer/net_error_helper_core.h

index aeb45bc7d09be99b5b477b9c37f5929b78a7d8be..1551553e9ffeaf2c1ff0a13e1d2a15ba1ee2bf5b 100644

--- a/components/error_page/renderer/net_error_helper_core.h

+++ b/components/error_page/renderer/net_error_helper_core.h

@@ -195,7 +195,7 @@ class NetErrorHelperCore {

bool ShouldSuppressErrorPage(FrameType frame_type, const GURL& url);

void set_timer_for_testing(std::unique_ptr<base::Timer> timer) {

- auto_reload_timer_.reset(timer.release());

+ auto_reload_timer_ = std::move(timer);

}

// Execute the effect of pressing the specified button.

« no previous file with comments | « no previous file | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »