Use unsigned longs in HTMLImageElement idl

third_party/WebKit/Source/core/html/HTMLImageElement.idl

Index: third_party/WebKit/Source/core/html/HTMLImageElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLImageElement.idl b/third_party/WebKit/Source/core/html/HTMLImageElement.idl
index ddad655d4157f1705009989575aa6274a4d1fb47..49bff7ef33750a60261a10967b4df08a7763f534 100644
--- a/third_party/WebKit/Source/core/html/HTMLImageElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLImageElement.idl
@@ -20,11 +20,10 @@
 
 // https://html.spec.whatwg.org/#the-img-element
 
-// TODO(foolip): All long types in this interfaces should be unsigned long.
 [
     ActiveScriptWrappable,
     ConstructorCallWith=Document,
-    NamedConstructor=Image(optional long width, optional long height),
+    NamedConstructor=Image(optional unsigned long width, optional unsigned long height),
 ] interface HTMLImageElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString alt;
     [CEReactions, Reflect, URL] attribute DOMString src;
@@ -33,10 +32,10 @@
     [CEReactions, Reflect, ReflectOnly=("anonymous","use-credentials"), ReflectEmpty="anonymous", ReflectInvalid="anonymous"] attribute DOMString? crossOrigin;
     [CEReactions, Reflect] attribute DOMString useMap;
     [CEReactions, Reflect] attribute boolean isMap;
-    [CEReactions] attribute long width;
-    [CEReactions] attribute long height;
-    readonly attribute long naturalWidth;
-    readonly attribute long naturalHeight;
+    [CEReactions] attribute unsigned long width;
+    [CEReactions] attribute unsigned long height;
+    readonly attribute unsigned long naturalWidth;

[foolip, 2016/11/10 16:53:33]

It looks these and x/y aren't actually changed in the implementation?

[rwlbuis, 2016/11/10 17:07:45]

For naturalWidth/Height it should not matter, since we are working with
width/height which are supposed to be unsigned.

For x/y, I do not see them listed here?
https://html.spec.whatwg.org/#the-img-element

If we can set them to negative x/y then obviously I'll not convert them to
unsigned long, let me know.

[foolip, 2016/11/11 09:47:22]

I mean that HTMLImageElement::naturalWidth() should be changed to unsigned, and
any callsites also need to be checked to see if they're treating it as signed or
unsigned.
They're in
https://drafts.csswg.org/cssom-view/#extensions-to-the-htmlimageelement-inter...
and aren't unsigned. Maybe file a spec issue if it makes sense to change them.

+    readonly attribute unsigned long naturalHeight;
     readonly attribute boolean complete;
     readonly attribute DOMString currentSrc;
     [CEReactions, Reflect, ReflectOnly=("","no-referrer","origin","no-referrer-when-downgrade","origin-when-cross-origin","unsafe-url"), ReflectMissing="", ReflectInvalid=""] attribute DOMString referrerPolicy;
@@ -54,6 +53,6 @@
 
     // CSSOM View Module
     // http://dev.w3.org/csswg/cssom-view/#extensions-to-the-htmlimageelement-interface
-    [MeasureAs=HTMLImageElementX] readonly attribute long x;
-    [MeasureAs=HTMLImageElementY] readonly attribute long y;
+    [MeasureAs=HTMLImageElementX] readonly attribute unsigned long x;
+    [MeasureAs=HTMLImageElementY] readonly attribute unsigned long y;
 };