Use unsigned longs in HTMLImageElement idl

third_party/WebKit/Source/core/html/HTMLImageElement.idl

 /*
  * Copyright (C) 2006, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 // https://html.spec.whatwg.org/#the-img-element
 
-// TODO(foolip): All long types in this interfaces should be unsigned long.
 [
     ActiveScriptWrappable,
     ConstructorCallWith=Document,
-    NamedConstructor=Image(optional long width, optional long height),
+    NamedConstructor=Image(optional unsigned long width, optional unsigned long height),
 ] interface HTMLImageElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString alt;
     [CEReactions, Reflect, URL] attribute DOMString src;
     [CEReactions, Reflect] attribute DOMString srcset;
     [CEReactions, Reflect] attribute DOMString sizes;
     [CEReactions, Reflect, ReflectOnly=("anonymous","use-credentials"), ReflectEmpty="anonymous", ReflectInvalid="anonymous"] attribute DOMString? crossOrigin;
     [CEReactions, Reflect] attribute DOMString useMap;
     [CEReactions, Reflect] attribute boolean isMap;
-    [CEReactions] attribute long width;
-    [CEReactions] attribute long height;
-    readonly attribute long naturalWidth;
-    readonly attribute long naturalHeight;
+    [CEReactions] attribute unsigned long width;
+    [CEReactions] attribute unsigned long height;
+    readonly attribute unsigned long naturalWidth;

[foolip, 2016/11/10 16:53:33]

It looks these and x/y aren't actually changed in the implementation?

[rwlbuis, 2016/11/10 17:07:45]

For naturalWidth/Height it should not matter, since we are working with
width/height which are supposed to be unsigned.

For x/y, I do not see them listed here?
https://html.spec.whatwg.org/#the-img-element

If we can set them to negative x/y then obviously I'll not convert them to
unsigned long, let me know.

[foolip, 2016/11/11 09:47:22]

I mean that HTMLImageElement::naturalWidth() should be changed to unsigned, and
any callsites also need to be checked to see if they're treating it as signed or
unsigned.
They're in
https://drafts.csswg.org/cssom-view/#extensions-to-the-htmlimageelement-inter...
and aren't unsigned. Maybe file a spec issue if it makes sense to change them.

+    readonly attribute unsigned long naturalHeight;
     readonly attribute boolean complete;
     readonly attribute DOMString currentSrc;
     [CEReactions, Reflect, ReflectOnly=("","no-referrer","origin","no-referrer-when-downgrade","origin-when-cross-origin","unsafe-url"), ReflectMissing="", ReflectInvalid=""] attribute DOMString referrerPolicy;
 
     // obsolete members
     // https://html.spec.whatwg.org/#HTMLImageElement-partial
     [CEReactions, Reflect] attribute DOMString name;
     [CEReactions, Reflect, URL] attribute DOMString lowsrc;
     [CEReactions, Reflect] attribute DOMString align;
     [CEReactions, Reflect] attribute unsigned long hspace;
     [CEReactions, Reflect] attribute unsigned long vspace;
     [CEReactions, Reflect, URL] attribute DOMString longDesc;
 
     [CEReactions, Reflect, TreatNullAs=EmptyString] attribute DOMString border;
 
     // CSSOM View Module
     // http://dev.w3.org/csswg/cssom-view/#extensions-to-the-htmlimageelement-interface
-    [MeasureAs=HTMLImageElementX] readonly attribute long x;
-    [MeasureAs=HTMLImageElementY] readonly attribute long y;
+    [MeasureAs=HTMLImageElementX] readonly attribute unsigned long x;
+    [MeasureAs=HTMLImageElementY] readonly attribute unsigned long y;
 };