Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2490153003: [Mojo Video Capture] Replace const scoped_refptr<T>& with scoped_refptr<T> and use std::move (Closed)

Created:
4 years, 1 month ago by chfremer
Modified:
4 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Replace const scoped_refptr<T>& with scoped_refptr<T> and use std::move Replace method signatures of touched code where const scoped_refptr<T>& is passed into a method with passing the smart pointer by value. This is to conform with updated Chromium style guidelines. Note, this also required reviewing all call sites and deciding whether or not the pointers should be copied or moved. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.9.2 BUG=584797 TEST=video_capture_unittests, content_unittests, capture_unittests [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Committed: https://crrev.com/2f830966c63bc055be0f17b10190ba2f69adf0f3 Cr-Commit-Position: refs/heads/master@{#431715}

Patch Set 1 #

Patch Set 2 : fix bots #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/screen_capture_device_android_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/content/thread_safe_capture_oracle.h View 2 chunks +4 lines, -3 lines 1 comment Download
M media/capture/content/thread_safe_capture_oracle.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/video_capture_device_client.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_jpeg_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_frame_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
chfremer
miu@: PTAL content/browser/media/* and media/capture/content/* mcasas@: PTAL content/browser/renderer_host/* and services/*
4 years, 1 month ago (2016-11-10 17:33:59 UTC) #4
chfremer
Since miu@ is OOO, sergeyu@: Please RS content/browser/media/* xhwang@: Please RS media/capture/content/*
4 years, 1 month ago (2016-11-11 16:58:07 UTC) #14
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-11 18:17:09 UTC) #15
xhwang
media/capture/content rs lgtm
4 years, 1 month ago (2016-11-11 18:17:36 UTC) #16
mcasas
lgtm https://codereview.chromium.org/2490153003/diff/20001/media/capture/content/thread_safe_capture_oracle.h File media/capture/content/thread_safe_capture_oracle.h (right): https://codereview.chromium.org/2490153003/diff/20001/media/capture/content/thread_safe_capture_oracle.h#newcode44 media/capture/content/thread_safe_capture_oracle.h:44: CaptureFrameCallback; nit: maybe update to 'using ... ?
4 years, 1 month ago (2016-11-11 23:46:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490153003/20001
4 years, 1 month ago (2016-11-11 23:47:50 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 00:52:00 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:58:48 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f830966c63bc055be0f17b10190ba2f69adf0f3
Cr-Commit-Position: refs/heads/master@{#431715}

Powered by Google App Engine
This is Rietveld 408576698