[Mojo Video Capture] Replace const scoped_refptr<T>& with scoped_refptr<T> and use std::move

media/capture/content/thread_safe_capture_oracle.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAPTURE_CONTENT_THREAD_SAFE_CAPTURE_ORACLE_H_
 #define MEDIA_CAPTURE_CONTENT_THREAD_SAFE_CAPTURE_ORACLE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 20 matching lines @@
     : public base::RefCountedThreadSafe<ThreadSafeCaptureOracle> {
  public:
   ThreadSafeCaptureOracle(std::unique_ptr<VideoCaptureDevice::Client> client,
                           const VideoCaptureParams& params,
                           bool enable_auto_throttling);
 
   // Called when a captured frame is available or an error has occurred.
   // If |success| is true then |frame| is valid and |timestamp| indicates when
   // the frame was painted.
   // If |success| is false, all other parameters are invalid.
-  typedef base::Callback<void(const scoped_refptr<VideoFrame>& frame,
+  typedef base::Callback<void(scoped_refptr<VideoFrame> frame,
                               base::TimeTicks timestamp,
-                              bool success)> CaptureFrameCallback;
+                              bool success)>
+      CaptureFrameCallback;

[mcasas, 2016/11/11 23:46:15]

nit: maybe update to 'using ... ?

 
   // Record a change |event| along with its |damage_rect| and |event_time|, and
   // then make a decision whether to proceed with capture. The decision is based
   // on recent event history, capture activity, and the availability of
   // resources.
   //
   // If this method returns false, the caller should take no further action.
   // Otherwise, |storage| is set to the destination for the video frame capture
   // and the caller should initiate capture.  Then, once the video frame has
   // been populated with its content, or if capture failed, the |callback|
@@ skipping 39 matching lines @@
  private:
   friend class base::RefCountedThreadSafe<ThreadSafeCaptureOracle>;
   virtual ~ThreadSafeCaptureOracle();
 
   // Callback invoked on completion of all captures.
   void DidCaptureFrame(
       int frame_number,
       std::unique_ptr<VideoCaptureDevice::Client::Buffer> buffer,
       base::TimeTicks capture_begin_time,
       base::TimeDelta estimated_frame_duration,
-      const scoped_refptr<VideoFrame>& frame,
+      scoped_refptr<VideoFrame> frame,
       base::TimeTicks reference_time,
       bool success);
 
   // Callback invoked once all consumers have finished with a delivered video
   // frame.  Consumer feedback signals are scanned from the frame's |metadata|.
   void DidConsumeFrame(int frame_number,
                        const media::VideoFrameMetadata* metadata);
 
   // Protects everything below it.
   mutable base::Lock lock_;
 
   // Recipient of our capture activity.
   std::unique_ptr<VideoCaptureDevice::Client> client_;
 
   // Makes the decision to capture a frame.
   VideoCaptureOracle oracle_;
 
   // The video capture parameters used to construct the oracle proxy.
   const VideoCaptureParams params_;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_CAPTURE_CONTENT_THREAD_SAFE_CAPTURE_ORACLE_H_