Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Issue 2489963003: Don't --find-copies-harder when printing informational diff, either (Closed)

Created:
4 years, 1 month ago by scottmg
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't --find-copies-harder when printing informational diff, either We're doing the diff twice afaict, once to print stats to the user, and once to actually do the upload. Definitely no need to --find-copies-harder in the print. Previously: https://codereview.chromium.org/2488823002. R=dpranke@chromium.org BUG=544889 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b84b5e3a137175c8afc3cc34100dbb59b097c2f1

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M git_cl.py View 1 chunk +1 line, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
scottmg
4 years, 1 month ago (2016-11-10 01:37:15 UTC) #1
Dirk Pranke
terrific. lgtm.
4 years, 1 month ago (2016-11-10 04:52:02 UTC) #6
tandrii(chromium)
lgtm % you probably need to update the tests.
4 years, 1 month ago (2016-11-10 10:12:35 UTC) #8
scottmg
On 2016/11/10 10:12:35, tandrii(chromium) wrote: > lgtm % you probably need to update the tests. ...
4 years, 1 month ago (2016-11-10 17:22:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489963003/20001
4 years, 1 month ago (2016-11-10 17:22:20 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 17:25:37 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b84b5e3a137175...

Powered by Google App Engine
This is Rietveld 408576698