Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2488823002: Default to not using --find-copies-harder (Closed)

Created:
4 years, 1 month ago by scottmg
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Default to not using --find-copies-harder It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as opposed to one that's in the current patch). BUG=544889 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae09f5fa13dc040f1b7afeaec552b45a1fdac5b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/upload.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
scottmg
4 years, 1 month ago (2016-11-08 21:07:16 UTC) #6
Dirk Pranke
lgtm. I don't even like --find-copies, but turning that off by default is probably a ...
4 years, 1 month ago (2016-11-08 21:30:06 UTC) #10
grt (UTC plus 2)
Thank you for sending this up, Scott!
4 years, 1 month ago (2016-11-08 21:32:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488823002/1
4 years, 1 month ago (2016-11-08 21:32:58 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:37:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae09f5fa13dc04...

Powered by Google App Engine
This is Rietveld 408576698