Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2489853004: Parameterizing tests to cover cross-site and same-site subframes. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, dcheng, site-isolation-reviews_chromium.org, paulmeyer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f28f069c99a5e92ff19cf327ea3642d650411035 Cr-Commit-Position: refs/heads/master@{#432525}

Patch Set 1 #

Patch Set 2 : Rebasing... #

Patch Set 3 : A few extra comments. #

Patch Set 4 : . #

Patch Set 5 : Rebasing... #

Patch Set 6 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc View 1 2 3 4 5 5 chunks +18 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (20 generated)
Łukasz Anforowicz
Nick, can you take a look please? (the redness in linux_site_isolation is a known, unrelated ...
4 years, 1 month ago (2016-11-15 00:04:14 UTC) #14
Łukasz Anforowicz
+Paul to CC Old tests only tested 1) drop and 2) drag-start in a frame ...
4 years, 1 month ago (2016-11-15 00:06:00 UTC) #15
ncarter (slow)
lgtm
4 years, 1 month ago (2016-11-15 18:19:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489853004/100001
4 years, 1 month ago (2016-11-16 16:03:51 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-16 17:06:22 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:18:13 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f28f069c99a5e92ff19cf327ea3642d650411035
Cr-Commit-Position: refs/heads/master@{#432525}

Powered by Google App Engine
This is Rietveld 408576698