|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Łukasz Anforowicz Modified:
4 years, 1 month ago Reviewers:
ncarter (slow) CC:
chromium-reviews, dcheng, site-isolation-reviews_chromium.org, paulmeyer Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionParameterizing tests to cover cross-site and same-site subframes.
BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/f28f069c99a5e92ff19cf327ea3642d650411035
Cr-Commit-Position: refs/heads/master@{#432525}
Patch Set 1 #Patch Set 2 : Rebasing... #Patch Set 3 : A few extra comments. #Patch Set 4 : . #Patch Set 5 : Rebasing... #Patch Set 6 : Rebasing... #Messages
Total messages: 26 (20 generated)
Description was changed from ========== Parameterized tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
lukasza@chromium.org changed reviewers: + nick@chromium.org
Nick, can you take a look please? (the redness in linux_site_isolation is a known, unrelated issue that should already be fixed by a test suppression that landed earlier today)
+Paul to CC Old tests only tested 1) drop and 2) drag-start in a frame cross-site from the main frame. The new tests enabled by this CL also cover testing the scenario where the subframe is from the same time as the main frame. I assume these new tests are useful - please shout if this is not the case.
lgtm
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lukasza@chromium.org
The CQ bit was checked by lukasza@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org Link to the patchset: https://codereview.chromium.org/2489853004/#ps100001 (title: "Rebasing...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Parameterizing tests to cover cross-site and same-site subframes. BUG=647249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f28f069c99a5e92ff19cf327ea3642d650411035 Cr-Commit-Position: refs/heads/master@{#432525} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f28f069c99a5e92ff19cf327ea3642d650411035 Cr-Commit-Position: refs/heads/master@{#432525} |
