Parameterizing tests to cover cross-site and same-site subframes.

chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 361 matching lines @@
   std::string expected_effect_allowed_ = "<no expectation>";
   std::string expected_mime_types_ = "<no expectation>";
 
   DISALLOW_COPY_AND_ASSIGN(DOMDragEventVerifier);
 };
 
 const char kTestPagePath[] = "/drag_and_drop/page.html";
 
 }  // namespace
 
-class DragAndDropBrowserTest : public InProcessBrowserTest {
+class DragAndDropBrowserTest : public InProcessBrowserTest,
+                               public testing::WithParamInterface<bool> {
  public:
   DragAndDropBrowserTest(){};
 
  protected:
   void SetUpOnMainThread() override {
     host_resolver()->AddRule("*", "127.0.0.1");
     ASSERT_TRUE(embedded_test_server()->Start());
     content::SetupCrossSiteRedirector(embedded_test_server());
     drag_simulator_.reset(new DragAndDropSimulator(web_contents()));
   }
 
+  bool use_cross_site_subframe() {
+    // This is controlled by gtest's test param from INSTANTIATE_TEST_CASE_P.
+    return GetParam();
+  }
+
   content::RenderFrameHost* left_frame() {
     AssertTestPageIsLoaded();
     return GetFrameByName("left");
   }
 
   content::RenderFrameHost* right_frame() {
     AssertTestPageIsLoaded();
     return GetFrameByName("right");
   }
 
@@ skipping 147 matching lines @@
 
   std::unique_ptr<DragAndDropSimulator> drag_simulator_;
 
   // Constants with coordinates within content/test/data/drag_and_drop/page.html
   const gfx::Point kMiddleOfLeftFrame = gfx::Point(200, 200);
   const gfx::Point kMiddleOfRightFrame = gfx::Point(400, 200);
 
   DISALLOW_COPY_AND_ASSIGN(DragAndDropBrowserTest);
 };
 
-IN_PROC_BROWSER_TEST_F(DragAndDropBrowserTest, DropTextFromOutside) {
+IN_PROC_BROWSER_TEST_P(DragAndDropBrowserTest, DropTextFromOutside) {
+  std::string frame_site = use_cross_site_subframe() ? "b.com" : "a.com";
   ASSERT_TRUE(NavigateToTestPage("a.com"));
-  ASSERT_TRUE(NavigateRightFrame("b.com", "drop_target.html"));
+  ASSERT_TRUE(NavigateRightFrame(frame_site, "drop_target.html"));
 
   // Setup test expectations.
   DOMDragEventVerifier expected_dom_event_data;
   expected_dom_event_data.set_expected_drop_effect("none");
   expected_dom_event_data.set_expected_effect_allowed("all");
   expected_dom_event_data.set_expected_mime_types("text/plain");
 
   // Drag text from outside the browser into/over the right frame.
   {
     DOMDragEventWaiter dragover_waiter("dragover", right_frame());
     ASSERT_TRUE(SimulateDragEnterToRightFrame("Dragged test text"));
 
     std::string dragover_event;
     ASSERT_TRUE(dragover_waiter.WaitForNextMatchingEvent(&dragover_event));
     EXPECT_THAT(dragover_event, expected_dom_event_data.Matches());
   }
 
   // Drop into the right frame.
   {
     DOMDragEventWaiter drop_waiter("drop", right_frame());
     ASSERT_TRUE(SimulateDropInRightFrame());
 
     std::string drop_event;
     ASSERT_TRUE(drop_waiter.WaitForNextMatchingEvent(&drop_event));
     EXPECT_THAT(drop_event, expected_dom_event_data.Matches());
   }
 }
 
-IN_PROC_BROWSER_TEST_F(DragAndDropBrowserTest, DragStartInFrame) {
-  std::string frame_site = "b.com";
+IN_PROC_BROWSER_TEST_P(DragAndDropBrowserTest, DragStartInFrame) {
+  std::string frame_site = use_cross_site_subframe() ? "b.com" : "a.com";
   ASSERT_TRUE(NavigateToTestPage("a.com"));
   ASSERT_TRUE(NavigateLeftFrame(frame_site, "image_source.html"));
 
   // Setup test expectations.
   // (dragstart event handler in image_source.html is asking for "copy" only).
   DOMDragEventVerifier expected_dom_event_data;
   expected_dom_event_data.set_expected_drop_effect("none");
   expected_dom_event_data.set_expected_effect_allowed("copy");
   expected_dom_event_data.set_expected_mime_types(
       "Files,text/html,text/uri-list");
@@ skipping 28 matching lines @@
                                       "\">"));
     EXPECT_EQ(expected_location_of_drag_start_in_left_frame(),
               location_inside_web_contents);
     EXPECT_EQ(ui::DragDropTypes::DRAG_COPY, operation);
   }
 
   // Try to leave everything in a clean state.
   SimulateMouseUp();
 }
 
+INSTANTIATE_TEST_CASE_P(
+    SameSiteSubframe, DragAndDropBrowserTest, ::testing::Values(false));
+
+INSTANTIATE_TEST_CASE_P(
+    CrossSiteSubframe, DragAndDropBrowserTest, ::testing::Values(true));
+
 }  // namespace chrome