Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2489853003: Add a Nougat Tester to chromium.android.fyi (Closed)

Created:
4 years, 1 month ago by bpastene
Modified:
4 years ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, hinoka
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : switch to android.fyi #

Patch Set 3 : add myself to OWNERS of android* #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -216 lines) Patch
M masters/master.chromium.android.fyi/builders.pyl View 1 4 chunks +33 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/OWNERS View 1 2 1 chunk +2 lines, -1 line 1 comment Download
M scripts/slave/recipe_modules/chromium_tests/chromium_android_fyi.py View 1 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json View 1 1 chunk +22 lines, -1 line 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Nougat_Phone_Tester.json View 1 11 chunks +107 lines, -206 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
bpastene
latp testing spec: https://codereview.chromium.org/2482793007/ https://codereview.chromium.org/2489853003/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_android.py File scripts/slave/recipe_modules/chromium_tests/chromium_android.py (left): https://codereview.chromium.org/2489853003/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_android.py#oldcode152 scripts/slave/recipe_modules/chromium_tests/chromium_android.py:152: 'Marshmallow 64 bit Tester': { ...
4 years, 1 month ago (2016-11-09 20:04:14 UTC) #2
jbudorick
I think this should start on chromium.android.fyi.
4 years, 1 month ago (2016-11-09 20:06:03 UTC) #3
bpastene
On 2016/11/09 20:06:03, jbudorick wrote: > I think this should start on chromium.android.fyi. Sure, but ...
4 years, 1 month ago (2016-11-09 20:09:58 UTC) #4
ghost stip (do not use)
https://s-media-cache-ak0.pinimg.com/originals/19/ef/9a/19ef9a4820f70eca4ff93e11f6f3d608.jpg
4 years, 1 month ago (2016-11-16 21:16:26 UTC) #5
bpastene
moved to fyi
4 years ago (2016-12-16 02:25:04 UTC) #7
jbudorick
lgtm
4 years ago (2016-12-16 15:32:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489853003/20001
4 years ago (2016-12-16 17:35:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/33218dd9f2249f10)
4 years ago (2016-12-16 17:54:17 UTC) #12
bpastene
stip@ and jbudorick@: Could I get your approval on OWNERS file changes for the latest ...
4 years ago (2016-12-16 18:04:02 UTC) #13
jbudorick
https://codereview.chromium.org/2489853003/diff/40001/scripts/slave/recipe_modules/chromium_tests/OWNERS File scripts/slave/recipe_modules/chromium_tests/OWNERS (right): https://codereview.chromium.org/2489853003/diff/40001/scripts/slave/recipe_modules/chromium_tests/OWNERS#newcode13 scripts/slave/recipe_modules/chromium_tests/OWNERS:13: per-file chromium_android*=bpastene@chromium.org lgtm
4 years ago (2016-12-16 18:06:41 UTC) #14
ghost stip (do not use)
lgtm
4 years ago (2016-12-16 20:13:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489853003/40001
4 years ago (2016-12-16 20:18:37 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-16 20:23:38 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/c723bc339ad1e5fd0013...

Powered by Google App Engine
This is Rietveld 408576698