Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: src/builtins/builtins-array.cc

Issue 2489743002: [stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-regexp.cc » ('j') | src/code-stub-assembler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-array.cc
diff --git a/src/builtins/builtins-array.cc b/src/builtins/builtins-array.cc
index 7e8c48668ff11cb36852eff96f67df69f7693ba4..39072d1d8667b7b11f7355eee51a1a44ce17a0e2 100644
--- a/src/builtins/builtins-array.cc
+++ b/src/builtins/builtins-array.cc
@@ -2179,14 +2179,14 @@ void Builtins::Generate_ArrayIteratorPrototypeNext(
assembler->Bind(&if_isfastarray);
{
- assembler->Assert(
+ assembler->CSA_ASSERT(
assembler->Word32Equal(assembler->LoadMapInstanceType(array_map),
assembler->Int32Constant(JS_ARRAY_TYPE)));
Node* length = assembler->LoadObjectField(array, JSArray::kLengthOffset);
- assembler->Assert(assembler->TaggedIsSmi(length));
- assembler->Assert(assembler->TaggedIsSmi(index));
+ assembler->CSA_ASSERT(assembler->TaggedIsSmi(length));
+ assembler->CSA_ASSERT(assembler->TaggedIsSmi(index));
assembler->GotoUnless(assembler->SmiBelow(index, length), &set_done);
@@ -2384,8 +2384,8 @@ void Builtins::Generate_ArrayIteratorPrototypeNext(
assembler->Bind(&done);
length = var_length.value();
}
- assembler->Assert(assembler->TaggedIsSmi(length));
- assembler->Assert(assembler->TaggedIsSmi(index));
+ assembler->CSA_ASSERT(assembler->TaggedIsSmi(length));
+ assembler->CSA_ASSERT(assembler->TaggedIsSmi(index));
assembler->GotoUnless(assembler->SmiBelow(index, length), &set_done);
« no previous file with comments | « no previous file | src/builtins/builtins-regexp.cc » ('j') | src/code-stub-assembler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698