src/builtins/builtins-regexp.cc - Issue 2489743002: [stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-regexp.cc

Issue 2489743002: [stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-regexp.cc

diff --git a/src/builtins/builtins-regexp.cc b/src/builtins/builtins-regexp.cc

index 40a99856b49d634777cfce7efe1aa43c2641d924..a5e9d04dd47386a20fcc7db3211fcf7c8ff68087 100644

--- a/src/builtins/builtins-regexp.cc

+++ b/src/builtins/builtins-regexp.cc

@@ -1677,7 +1677,7 @@ compiler::Node* ReplaceGlobalCallableFastPath(

a->Bind(&if_isstring);

{

- a->Assert(a->IsStringInstanceType(a->LoadInstanceType(elem)));

+ a->CSA_ASSERT(a->IsStringInstanceType(a->LoadInstanceType(elem)));

Callable call_callable = CodeFactory::Call(isolate);

Node* const replacement_obj =