[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode.

[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside [Assert / ]Assert brackets.

BUG=

Committed: https://crrev.com/0700bc1bf82089e10038f62528e375bcb6f22a0c
Cr-Commit-Position: refs/heads/master@{#40869}

[Igor Sheludko, 2016-11-08 22:54:37]

Description was changed from

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

BUG=
==========

to

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

[Igor Sheludko, 2016-11-08 22:54:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:54:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:23:54]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-11-08 23:49:44]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org, jkummerow@chromium.org

[Igor Sheludko, 2016-11-08 23:49:45]

Benedikt, PTAL interpreter
Jakob, PTAL the rest

[Benedikt Meurer, 2016-11-09 04:52:09]

https://codereview.chromium.org/2489743002/diff/1/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2489743002/diff/1/src/code-stub-assembler.h#n...
src/code-stub-assembler.h:1266: #define CSA_ASSERT(x) Assert([&] { return (x);
}, #x, __FILE__, __LINE__)
Can we please, please find a less awkward syntax for this? How about not having
this terrible macro at all, and just using the higher-order Assert function, and
have that generate code only in debug mode?

[Igor Sheludko, 2016-11-09 12:10:34]

https://codereview.chromium.org/2489743002/diff/1/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2489743002/diff/1/src/code-stub-assembler.h#n...
src/code-stub-assembler.h:1266: #define CSA_ASSERT(x) Assert([&] { return (x);
}, #x, __FILE__, __LINE__)
On 2016/11/09 04:52:09, Benedikt Meurer wrote:
> Can we please, please find a less awkward syntax for this? How about not
having
> this terrible macro at all, and just using the higher-order Assert function,
and
> have that generate code only in debug mode?

Ok, I can remove this lambda code.

[Igor Sheludko, 2016-11-09 16:48:35]

Description was changed from

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

to

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

[Igor Sheludko, 2016-11-09 16:48:59]

Addressed offline comments. PTAL

[Igor Sheludko, 2016-11-09 16:49:09]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 16:49:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 16:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 16:50:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15940)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28171)

[Igor Sheludko, 2016-11-09 16:58:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 16:58:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-09 17:05:36]

Patchset #5 (id:80001) has been deleted

[Igor Sheludko, 2016-11-09 17:06:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 17:06:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-11-09 17:12:49]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-11-09 17:12:49]

Interpreter LGTM

[commit-bot: I haz the power, 2016-11-09 17:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:33:04]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-11-09 17:46:00]

lgtm

[Igor Sheludko, 2016-11-09 17:53:46]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-09 17:53:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2489743002/#ps120001
(title: "((void)0)")

[commit-bot: I haz the power, 2016-11-09 17:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-11-09 18:05:58]

LGTM, thanks!

[commit-bot: I haz the power, 2016-11-09 18:22:13]

Description was changed from

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

to

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

[commit-bot: I haz the power, 2016-11-09 18:22:15]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-11-17 22:27:56]

Description was changed from

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=
==========

to

==========
[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions
in release mode.

... and make them applicable outside of CSA.

Nice bonus is that the assert condition instructions will now appear inside
[Assert / ]Assert brackets.

BUG=

Committed: https://crrev.com/0700bc1bf82089e10038f62528e375bcb6f22a0c
Cr-Commit-Position: refs/heads/master@{#40869}
==========

[commit-bot: I haz the power, 2016-11-17 22:27:58]

Patchset 6 (id:??) landed as
https://crrev.com/0700bc1bf82089e10038f62528e375bcb6f22a0c
Cr-Commit-Position: refs/heads/master@{#40869}