[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/ast/ast.h"
 #include "src/bootstrapper.h"
@@ skipping 1736 matching lines @@
         // Load the HeapNumber value.
         var_finc_value.Bind(assembler->LoadHeapNumberValue(value));
         assembler->Goto(&do_finc);
       }
 
       assembler->Bind(&if_valuenotnumber);
       {
         // We do not require an Or with earlier feedback here because once we
         // convert the value to a number, we cannot reach this path. We can
         // only reach this path on the first pass when the feedback is kNone.
-        assembler->Assert(assembler->Word32Equal(
-            var_type_feedback.value(),
-            assembler->Int32Constant(BinaryOperationFeedback::kNone)));
+        CSA_ASSERT(assembler,
+                   assembler->Word32Equal(var_type_feedback.value(),
+                                          assembler->Int32Constant(
+                                              BinaryOperationFeedback::kNone)));
 
         Label if_valueisoddball(assembler), if_valuenotoddball(assembler);
         Node* instance_type = assembler->LoadMapInstanceType(value_map);
         Node* is_oddball = assembler->Word32Equal(
             instance_type, assembler->Int32Constant(ODDBALL_TYPE));
         assembler->Branch(is_oddball, &if_valueisoddball, &if_valuenotoddball);
 
         assembler->Bind(&if_valueisoddball);
         {
           // Convert Oddball to Number and check again.
@@ skipping 116 matching lines @@
         // Load the HeapNumber value.
         var_fdec_value.Bind(assembler->LoadHeapNumberValue(value));
         assembler->Goto(&do_fdec);
       }
 
       assembler->Bind(&if_valuenotnumber);
       {
         // We do not require an Or with earlier feedback here because once we
         // convert the value to a number, we cannot reach this path. We can
         // only reach this path on the first pass when the feedback is kNone.
-        assembler->Assert(assembler->Word32Equal(
-            var_type_feedback.value(),
-            assembler->Int32Constant(BinaryOperationFeedback::kNone)));
+        CSA_ASSERT(assembler,
+                   assembler->Word32Equal(var_type_feedback.value(),
+                                          assembler->Int32Constant(
+                                              BinaryOperationFeedback::kNone)));
 
         Label if_valueisoddball(assembler), if_valuenotoddball(assembler);
         Node* instance_type = assembler->LoadMapInstanceType(value_map);
         Node* is_oddball = assembler->Word32Equal(
             instance_type, assembler->Int32Constant(ODDBALL_TYPE));
         assembler->Branch(is_oddball, &if_valueisoddball, &if_valuenotoddball);
 
         assembler->Bind(&if_valueisoddball);
         {
           // Convert Oddball to Number and check again.
@@ skipping 655 matching lines @@
   assembler->GotoIf(is_async, &if_async);
 
   Node* is_class_constructor = assembler->Word32And(
       compiler_hints,
       assembler->Int32Constant(FunctionKind::kClassConstructor
                                << SharedFunctionInfo::kFunctionKindShift));
   assembler->GotoIf(is_class_constructor, &if_class_constructor);
 
   if (FLAG_debug_code) {
     // Function must be a function without a prototype.
-    assembler->Assert(assembler->Word32And(
-        compiler_hints,
-        assembler->Int32Constant((FunctionKind::kAccessorFunction |
-                                  FunctionKind::kArrowFunction |
-                                  FunctionKind::kConciseMethod)
-                                 << SharedFunctionInfo::kFunctionKindShift)));
+    CSA_ASSERT(assembler, assembler->Word32And(
+                              compiler_hints,
+                              assembler->Int32Constant(
+                                  (FunctionKind::kAccessorFunction |
+                                   FunctionKind::kArrowFunction |
+                                   FunctionKind::kConciseMethod)
+                                  << SharedFunctionInfo::kFunctionKindShift)));
   }
   assembler->Goto(&if_function_without_prototype);
 
   assembler->Bind(&if_normal);
   {
     map_index.Bind(assembler->Select(
         is_strict,
         assembler->IntPtrConstant(Context::STRICT_FUNCTION_MAP_INDEX),
         assembler->IntPtrConstant(Context::SLOPPY_FUNCTION_MAP_INDEX)));
     assembler->Goto(&load_map);
@@ skipping 729 matching lines @@
 
   if (type == MachineType::Pointer()) {
     return Representation::External();
   }
 
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8