chromeos: Make system tray audio item observe CrasAudioHandler directly

chromeos: Make system tray audio item observe CrasAudioHandler directly

For mustash the chrome browser process will not be able to directly access
code in ash (e.g. WmShell). This CL reduces chrome's dependency on ash
in SystemTrayDelegateChromeos by having the ash TrayAudio class observe
CrasAudioHandler directly.

This also allows one extra layer of observers (ash::AudioObserver) to be
deleted.

WmRootWindowController now exposes SystemTray because ARC++ needs to show
the volume popup sometimes. That has to happen on all monitors, so TrayAudio
needs to be able to iterate through all SystemTrays.

BUG=661247, 647412
TEST=added to ash_unittests, also modified the code to trigger the volume
popup manually and tested at the login screen with an external display, also
tested on device with ARC++ and Netflix app

Committed: https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e
Cr-Commit-Position: refs/heads/master@{#431608}

[James Cook, 2016-11-09 19:09:10]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 19:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-09 19:09:31]

jamescook@chromium.org changed reviewers:
+ jennyz@chromium.org

[James Cook, 2016-11-09 19:09:32]

jennyz, please take a look.

[commit-bot: I haz the power, 2016-11-09 19:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:13:02]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jennyz, 2016-11-09 23:22:05]

LGTM.

Are you going to merge TrayAudio and TrayAudioChromeOs later?

[James Cook, 2016-11-09 23:27:56]

On 2016/11/09 23:22:05, jennyz wrote:
> LGTM.
> 
> Are you going to merge TrayAudio and TrayAudioChromeOs later?

https://codereview.chromium.org/2483393002 (the ancestor of this patch) combines
them. I sent you that patch yesterday.

[James Cook, 2016-11-09 23:30:07]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org, yusukes@chromium.org

[James Cook, 2016-11-09 23:30:07]

msw, can I get OWNERS for c/b/ui/ash ?

yusukes, can I get OWNERS for components/arc ?

[Yusuke Sato, 2016-11-09 23:39:28]

lgtm

[msw, 2016-11-09 23:48:36]

c/b/ui/ash/* lgtm

[jennyz, 2016-11-10 23:22:23]

LGTM with a nit.

[jennyz, 2016-11-11 00:07:29]

On 2016/11/10 23:22:23, jennyz wrote:
> LGTM with a nit.

Sorry, the nit is not for this cl.

[James Cook, 2016-11-11 17:08:47]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-11-11 17:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
yusukes@chromium.org, jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2489723005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-11 17:09:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:05:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 19:30:26]

Description was changed from

==========
chromeos: Make system tray audio item observe CrasAudioHandler directly

For mustash the chrome browser process will not be able to directly access
code in ash (e.g. WmShell). This CL reduces chrome's dependency on ash
in SystemTrayDelegateChromeos by having the ash TrayAudio class observe
CrasAudioHandler directly.

This also allows one extra layer of observers (ash::AudioObserver) to be
deleted.

WmRootWindowController now exposes SystemTray because ARC++ needs to show
the volume popup sometimes. That has to happen on all monitors, so TrayAudio
needs to be able to iterate through all SystemTrays.

BUG=661247,647412
TEST=added to ash_unittests, also modified the code to trigger the volume
popup manually and tested at the login screen with an external display, also
tested on device with ARC++ and Netflix app
==========

to

==========
chromeos: Make system tray audio item observe CrasAudioHandler directly

For mustash the chrome browser process will not be able to directly access
code in ash (e.g. WmShell). This CL reduces chrome's dependency on ash
in SystemTrayDelegateChromeos by having the ash TrayAudio class observe
CrasAudioHandler directly.

This also allows one extra layer of observers (ash::AudioObserver) to be
deleted.

WmRootWindowController now exposes SystemTray because ARC++ needs to show
the volume popup sometimes. That has to happen on all monitors, so TrayAudio
needs to be able to iterate through all SystemTrays.

BUG=661247,647412
TEST=added to ash_unittests, also modified the code to trigger the volume
popup manually and tested at the login screen with an external display, also
tested on device with ARC++ and Netflix app

Committed: https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e
Cr-Commit-Position: refs/heads/master@{#431608}
==========

[commit-bot: I haz the power, 2016-11-11 19:30:28]

Patchset 3 (id:??) landed as
https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e
Cr-Commit-Position: refs/heads/master@{#431608}