chromeos: Combine TrayAudio and TrayAudioChromeOs classes

chromeos: Combine TrayAudio and TrayAudioChromeOs classes

The two classes were split when we supported ash on Windows. We don't support
ash on Windows anymore, so the two can be combined. This is a pure refactor
with no functional changes.

After doing this we can make TrayAudio directly observe CrasAudioHandler, which
will eliminate the audio observer code in SystemTrayNotifier and allow some
ash-specific code to be removed from chrome's SystemTrayDelegateChromeos.

This also moves all tray audio code into ash/common/system/chromeos/audio.

TODO: Eliminate TrayAudioDelegate and inline the code into TrayAudio.

BUG=661247
TEST=manual testing on device of input switching and volume changes

Committed: https://crrev.com/96ea4cf812df1ac6c0a0dbd5eed579a2fb1c7e39
Cr-Commit-Position: refs/heads/master@{#431479}

[James Cook, 2016-11-09 00:56:03]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 00:56:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-09 01:00:59]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-11-09 01:01:19]

jamescook@chromium.org changed reviewers:
+ jennyz@chromium.org

[James Cook, 2016-11-09 01:01:20]

jennyz, please take a look.

[commit-bot: I haz the power, 2016-11-09 01:01:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 02:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 02:17:37]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-11-09 16:37:07]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 16:37:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 17:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:31:15]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-11-10 00:20:07]

On 2016/11/09 01:01:20, James Cook wrote:
> jennyz, please take a look.

jennyz, friendly ping?

[jennyz, 2016-11-11 00:07:55]

lgtm with a nit

https://codereview.chromium.org/2483393002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/audio/tray_audio.cc (right):

https://codereview.chromium.org/2483393002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/audio/tray_audio.cc:72: volume_view_ = NULL;
NULL -> nullptr

[James Cook, 2016-11-11 01:32:44]

Thanks for the review.

https://codereview.chromium.org/2483393002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/audio/tray_audio.cc (right):

https://codereview.chromium.org/2483393002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/audio/tray_audio.cc:72: volume_view_ = NULL;
On 2016/11/11 00:07:55, jennyz wrote:
> NULL -> nullptr

Done.

[James Cook, 2016-11-11 01:54:45]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-11-11 01:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2483393002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-11 01:55:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:10:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-11 03:15:40]

Description was changed from

==========
chromeos: Combine TrayAudio and TrayAudioChromeOs classes

The two classes were split when we supported ash on Windows. We don't support
ash on Windows anymore, so the two can be combined. This is a pure refactor
with no functional changes.

After doing this we can make TrayAudio directly observe CrasAudioHandler, which
will eliminate the audio observer code in SystemTrayNotifier and allow some
ash-specific code to be removed from chrome's SystemTrayDelegateChromeos.

This also moves all tray audio code into ash/common/system/chromeos/audio.

TODO: Eliminate TrayAudioDelegate and inline the code into TrayAudio.

BUG=661247
TEST=manual testing on device of input switching and volume changes
==========

to

==========
chromeos: Combine TrayAudio and TrayAudioChromeOs classes

The two classes were split when we supported ash on Windows. We don't support
ash on Windows anymore, so the two can be combined. This is a pure refactor
with no functional changes.

After doing this we can make TrayAudio directly observe CrasAudioHandler, which
will eliminate the audio observer code in SystemTrayNotifier and allow some
ash-specific code to be removed from chrome's SystemTrayDelegateChromeos.

This also moves all tray audio code into ash/common/system/chromeos/audio.

TODO: Eliminate TrayAudioDelegate and inline the code into TrayAudio.

BUG=661247
TEST=manual testing on device of input switching and volume changes

Committed: https://crrev.com/96ea4cf812df1ac6c0a0dbd5eed579a2fb1c7e39
Cr-Commit-Position: refs/heads/master@{#431479}
==========

[commit-bot: I haz the power, 2016-11-11 03:15:42]

Patchset 6 (id:??) landed as
https://crrev.com/96ea4cf812df1ac6c0a0dbd5eed579a2fb1c7e39
Cr-Commit-Position: refs/heads/master@{#431479}