Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2489713002: Remove getter p on double in the VM to control fractional precision. (Closed)

Created:
4 years, 1 month ago by regis
Modified:
4 years, 1 month ago
Reviewers:
floitsch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove getter p on double in the VM to control fractional precision. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/80f289e54d6eae1a31c4a3d883aa37cad48690fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
M runtime/lib/double.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/standalone/fixed_precision_double_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
regis
4 years, 1 month ago (2016-11-08 22:08:47 UTC) #2
siva
4 years, 1 month ago (2016-11-09 18:51:41 UTC) #4
siva
lgtm
4 years, 1 month ago (2016-11-09 18:54:09 UTC) #5
regis
4 years, 1 month ago (2016-11-09 18:56:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80f289e54d6eae1a31c4a3d883aa37cad48690fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698