Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: runtime/lib/double.dart

Issue 2489713002: Remove getter p on double in the VM to control fractional precision. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/standalone/fixed_precision_double_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class _Double implements double { 5 class _Double implements double {
6 factory _Double.fromInteger(int value) 6 factory _Double.fromInteger(int value)
7 native "Double_doubleFromInteger"; 7 native "Double_doubleFromInteger";
8 8
9 // TODO: Make a stared static method for hashCode and _identityHashCode 9 // TODO: Make a stared static method for hashCode and _identityHashCode
10 // when semantics are corrected as described in: 10 // when semantics are corrected as described in:
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 } else { 268 } else {
269 return EQUAL; 269 return EQUAL;
270 } 270 }
271 } else if (isNaN) { 271 } else if (isNaN) {
272 return other.isNaN ? EQUAL : GREATER; 272 return other.isNaN ? EQUAL : GREATER;
273 } else { 273 } else {
274 // Other is NaN. 274 // Other is NaN.
275 return LESS; 275 return LESS;
276 } 276 }
277 } 277 }
278
279 static const int _FRACTIONAL_BITS = // Bits to keep after the decimal point.
280 const int.fromEnvironment("doubleFractionalBits", defaultValue: 20);
281 static const double _BIAS = 1.5 * (1 << (52 - _FRACTIONAL_BITS));
282
283 // Returns this with only _FRACTIONAL_BITS bits after the decimal point.
284 double get p => this + _BIAS - _BIAS;
285 } 278 }
OLDNEW
« no previous file with comments | « no previous file | tests/standalone/fixed_precision_double_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698