[Sync] Make all ModelTypeStore write methods go through WriteBatch.

[Sync] Make all ModelTypeStore write methods go through WriteBatch.

This makes it semantically clearer that the changes are contained in the
WriteBatch, and hides all the write functions pertaining to metadata
from ModelTypeStore consumers.

BUG=661837
Committed: https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2
Cr-Commit-Position: refs/heads/master@{#430805}

[maxbogue, 2016-11-08 21:00:30]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[maxbogue, 2016-11-08 21:00:53]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-11-08 21:00:53]

Pavel, PTAL! I'm very pleased with how this turned out.

[commit-bot: I haz the power, 2016-11-08 21:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 22:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:51:07]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-11-08 23:53:53]

lgtm

https://codereview.chromium.org/2489683002/diff/1/components/sync/model/model...
File components/sync/model/model_type_store.h (right):

https://codereview.chromium.org/2489683002/diff/1/components/sync/model/model...
components/sync/model/model_type_store.h:177:
FRIEND_TEST_ALL_PREFIXES(ModelTypeStoreImplTest, CorruptEntityMetadata);
I usually befriend test class and add helper functions for individual methods
there. This way non-public members are only accessed in methods of test class,
no need to scan test cases' code for them. Also list of friends doesn't grow
with addition of test cases.

[maxbogue, 2016-11-09 00:14:04]

https://codereview.chromium.org/2489683002/diff/1/components/sync/model/model...
File components/sync/model/model_type_store.h (right):

https://codereview.chromium.org/2489683002/diff/1/components/sync/model/model...
components/sync/model/model_type_store.h:177:
FRIEND_TEST_ALL_PREFIXES(ModelTypeStoreImplTest, CorruptEntityMetadata);
On 2016/11/08 23:53:53, pavely wrote:
> I usually befriend test class and add helper functions for individual methods
> there. This way non-public members are only accessed in methods of test class,
> no need to scan test cases' code for them. Also list of friends doesn't grow
> with addition of test cases.

Makes sense; done!

[maxbogue, 2016-11-09 00:14:10]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-11-09 00:14:10]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2489683002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-11-09 00:14:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 01:21:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 01:24:37]

Description was changed from

==========
[Sync] Make all ModelTypeStore write methods go through WriteBatch.

This makes it semantically clearer that the changes are contained in the
WriteBatch, and hides all the write functions pertaining to metadata
from ModelTypeStore consumers.

BUG=661837
==========

to

==========
[Sync] Make all ModelTypeStore write methods go through WriteBatch.

This makes it semantically clearer that the changes are contained in the
WriteBatch, and hides all the write functions pertaining to metadata
from ModelTypeStore consumers.

BUG=661837

Committed: https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2
Cr-Commit-Position: refs/heads/master@{#430805}
==========

[commit-bot: I haz the power, 2016-11-09 01:24:38]

Patchset 2 (id:??) landed as
https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2
Cr-Commit-Position: refs/heads/master@{#430805}