components/sync/model_impl/model_type_store_impl.h - Issue 2489683002: [Sync] Make all ModelTypeStore write methods go through WriteBatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model_impl/model_type_store_impl.h

Issue 2489683002: [Sync] Make all ModelTypeStore write methods go through WriteBatch. (Closed)

Patch Set: Address comment. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model_impl/model_type_store_impl.h

diff --git a/components/sync/model_impl/model_type_store_impl.h b/components/sync/model_impl/model_type_store_impl.h

index 67ca71b1144116aa8e1eb0a902f6db74415a8618..f9b67336981790ef2a50238c84bbd9d648e7a746 100644

--- a/components/sync/model_impl/model_type_store_impl.h

+++ b/components/sync/model_impl/model_type_store_impl.h

@@ -46,6 +46,9 @@ class ModelTypeStoreImpl : public ModelTypeStore, public base::NonThreadSafe {

std::unique_ptr<WriteBatch> CreateWriteBatch() override;

void CommitWriteBatch(std::unique_ptr<WriteBatch> write_batch,

const CallbackWithResult& callback) override;

+ protected:

+ // ModelTypeStore implementation.

void WriteData(WriteBatch* write_batch,

const std::string& id,

const std::string& value) override;