Issue 248963002: Making LayoutUnit conversions to Int types explicit in core/accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248963002: Making LayoutUnit conversions to Int types explicit in core/accessibility (Closed)

Created:
6 years, 8 months ago by gnana

Modified:
6 years, 8 months ago

Reviewers:
leviw_travelin_and_unemployed, eae

CC:
blink-reviews, dmazzoni, aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@patch3

Visibility:
Public.

More Reviews

Description

Making LayoutUnit conversions to Int types explicit in core/accessibility LayoutUnit misuse, often from improper conversion to other types, is a constant source of bugs in Blink. These conversion sites were discovered by toggling the int conversions to explicit and finding the compiler errors. BUG=350474 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172455

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	Source/core/accessibility/AXInlineTextBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXObject.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/248963002/1

6 years, 8 months ago (2014-04-24 04:06:09 UTC) #4

Message was sent while issue was closed.

Change committed as 172455

Expand Messages | Collapse Messages