Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: Source/core/accessibility/AXInlineTextBox.cpp

Issue 248963002: Making LayoutUnit conversions to Int types explicit in core/accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@patch3
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/accessibility/AXObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013, Google Inc. All rights reserved. 2 * Copyright (C) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 unsigned len = m_inlineTextBox->len(); 92 unsigned len = m_inlineTextBox->len();
93 Vector<float> widths; 93 Vector<float> widths;
94 m_inlineTextBox->characterWidths(widths); 94 m_inlineTextBox->characterWidths(widths);
95 ASSERT(widths.size() == len); 95 ASSERT(widths.size() == len);
96 offsets.resize(len); 96 offsets.resize(len);
97 97
98 float widthSoFar = 0; 98 float widthSoFar = 0;
99 for (unsigned i = 0; i < len; i++) { 99 for (unsigned i = 0; i < len; i++) {
100 widthSoFar += widths[i]; 100 widthSoFar += widths[i];
101 offsets[i] = LayoutUnit::fromFloatRound(widthSoFar); 101 offsets[i] = lroundf(widthSoFar);
102 } 102 }
103 } 103 }
104 104
105 void AXInlineTextBox::wordBoundaries(Vector<PlainTextRange>& words) const 105 void AXInlineTextBox::wordBoundaries(Vector<PlainTextRange>& words) const
106 { 106 {
107 if (!m_inlineTextBox) 107 if (!m_inlineTextBox)
108 return; 108 return;
109 109
110 Vector<AbstractInlineTextBox::WordBoundaries> wordBoundaries; 110 Vector<AbstractInlineTextBox::WordBoundaries> wordBoundaries;
111 m_inlineTextBox->wordBoundaries(wordBoundaries); 111 m_inlineTextBox->wordBoundaries(wordBoundaries);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 case AbstractInlineTextBox::TopToBottom: 144 case AbstractInlineTextBox::TopToBottom:
145 return AccessibilityTextDirectionTopToBottom; 145 return AccessibilityTextDirectionTopToBottom;
146 case AbstractInlineTextBox::BottomToTop: 146 case AbstractInlineTextBox::BottomToTop:
147 return AccessibilityTextDirectionBottomToTop; 147 return AccessibilityTextDirectionBottomToTop;
148 } 148 }
149 149
150 return AccessibilityTextDirectionLeftToRight; 150 return AccessibilityTextDirectionLeftToRight;
151 } 151 }
152 152
153 } // namespace WebCore 153 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/accessibility/AXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698