Issue 2489563004: [turbofan] Add support for accessing Uint8ClampedArrays.

Issue 2489563004: [turbofan] Add support for accessing Uint8ClampedArrays. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer

Modified:
4 years, 1 month ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Add support for accessing Uint8ClampedArrays. This adds a new NumberToUint8Clamped simplified operator that does the round ties to even + clamping necessary to store to Uint8ClampedArrays. BUG=v8:4470, v8:5267, v8:5615 R=jarin@chromium.org Committed: https://crrev.com/82b315ce75c0404f287a3214824ff262d7a44142 Cr-Commit-Position: refs/heads/master@{#40861}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+387 lines, -81 lines)			Patch
M	src/compiler/access-info.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/effect-control-linearizer.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/compiler/effect-control-linearizer.cc	View		4 chunks	+183 lines, -79 lines	0 comments	Download
M	src/compiler/js-native-context-specialization.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/compiler/opcodes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/operation-typer.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View		2 chunks	+90 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-operator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/simplified-operator.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/type-cache.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/typed-optimization.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/typed-optimization.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/compiler/verifier.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/compiler/uint8-clamped-array.js	View		1 chunk	+73 lines, -0 lines	0 comments	Download

Total messages: 13 (7 generated)

Benedikt Meurer

Hey Jaro, Here's the support for the last missing typed array kind. Please take a ...

4 years, 1 month ago (2016-11-09 13:01:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489563004/20001

4 years, 1 month ago (2016-11-09 13:13:49 UTC) #10

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:27:32 UTC) #13

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/82b315ce75c0404f287a3214824ff262d7a44142
Cr-Commit-Position: refs/heads/master@{#40861}