Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2489513003: Fixes and test updates for aura-mus (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes and test updates for aura-mus This addresses the following: . Wires up WindowPortMus::OnDeviceScaleFactorChanged() correctly. . Properly routes DesktopWindowTreeHostMus::SetSize(). It needs to go to WindowTreeHost, which then updates window(). . Makes DesktopWindowTreeHostMus::Show/Hide call to the appropriate Widget functions . Honors min/max size. And updates some tests that are relying on specific NativeWidgetAura functionality to create NativeWidgetAura. BUG=660994 TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/2e7a168a82cebe5fbb355cb05401c4827758aa94 Cr-Commit-Position: refs/heads/master@{#430828}

Patch Set 1 #

Total comments: 12

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M ui/aura/mus/window_port_mus.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 3 chunks +36 lines, -3 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views_unittest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sky
4 years, 1 month ago (2016-11-08 22:07:04 UTC) #1
msw
lgtm with nits https://codereview.chromium.org/2489513003/diff/1/ui/views/mus/desktop_window_tree_host_mus.cc File ui/views/mus/desktop_window_tree_host_mus.cc (right): https://codereview.chromium.org/2489513003/diff/1/ui/views/mus/desktop_window_tree_host_mus.cc#newcode128 ui/views/mus/desktop_window_tree_host_mus.cc:128: // TODO: handle device scale. optional ...
4 years, 1 month ago (2016-11-08 23:38:27 UTC) #4
sky
https://codereview.chromium.org/2489513003/diff/1/ui/views/mus/desktop_window_tree_host_mus.cc File ui/views/mus/desktop_window_tree_host_mus.cc (right): https://codereview.chromium.org/2489513003/diff/1/ui/views/mus/desktop_window_tree_host_mus.cc#newcode128 ui/views/mus/desktop_window_tree_host_mus.cc:128: // TODO: handle device scale. On 2016/11/08 23:38:27, msw ...
4 years, 1 month ago (2016-11-09 00:06:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489513003/20001
4 years, 1 month ago (2016-11-09 00:06:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 02:09:52 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 02:15:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e7a168a82cebe5fbb355cb05401c4827758aa94
Cr-Commit-Position: refs/heads/master@{#430828}

Powered by Google App Engine
This is Rietveld 408576698