Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 2489513003: Fixes and test updates for aura-mus (Closed)
Patch Set: feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/touchui/touch_selection_menu_runner_views_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index bad9edd96f4c760a9a701112e1448bf2031b5596..ec0f1eb5cc8a4a66b0a81ad8bf0bfd9c254b4b2b 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -847,6 +847,10 @@ TEST_F(WidgetObserverTest, DISABLED_VisibilityChange) {
}
TEST_F(WidgetObserverTest, DestroyBubble) {
+ // This test expect NativeWidgetAura, force its creation.
+ ViewsDelegate::GetInstance()->set_native_widget_factory(
+ ViewsDelegate::NativeWidgetFactory());
+
WidgetAutoclosePtr anchor(CreateTopLevelPlatformWidget());
anchor->Show();
@@ -1271,6 +1275,11 @@ TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
}
TEST_F(WidgetTest, BubbleControlsResetOnInit) {
+ // This test creates a NativeWidgetAura and then a bubble parented to it. This
+ // means the test needs a NativeWidgetAura for the bubble as well.
+ ViewsDelegate::GetInstance()->set_native_widget_factory(
+ ViewsDelegate::NativeWidgetFactory());
+
WidgetAutoclosePtr anchor(CreateTopLevelPlatformWidget());
anchor->Show();
« no previous file with comments | « ui/views/touchui/touch_selection_menu_runner_views_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698