Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2489473002: Moving code that clears the bisect_results directory to the right place. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Moving code that clears the bisect_results directory to the right place. This might have been the cause of the problems in the bug. The results directory getting cleared once for every revision. TBR=dtu@chromium.org BUG=662180 Committed: https://chromium.googlesource.com/chromium/tools/build/+/7420f0cb19fbb27d7a519248891f540e5a031f46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1120 lines, -7331 lines) Patch
M scripts/slave/recipe_modules/auto_bisect_staging/api.py View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/bad_config.json View 1 chunk +50 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json View 11 chunks +66 lines, -546 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json View 11 chunks +50 lines, -530 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json View 11 chunks +50 lines, -530 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json View 2 chunks +50 lines, -53 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_reference_range.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_revision.json View 4 chunks +50 lines, -159 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json View 14 chunks +66 lines, -705 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json View 12 chunks +58 lines, -591 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json View 5 chunks +50 lines, -212 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json View 19 chunks +56 lines, -960 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json View 13 chunks +56 lines, -642 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/failure_in_ref_range.json View 3 chunks +50 lines, -106 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_basic_device.json View 8 chunks +50 lines, -371 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json View 20 chunks +64 lines, -1021 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json View 8 chunks +50 lines, -371 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
RobertoCN
4 years, 1 month ago (2016-11-08 00:44:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489473002/1
4 years, 1 month ago (2016-11-08 01:00:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/7420f0cb19fbb27d7a519248891f540e5a031f46
4 years, 1 month ago (2016-11-08 01:11:14 UTC) #6
dtu
4 years, 1 month ago (2016-11-08 01:44:50 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698