Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/api.py

Issue 2489473002: Moving code that clears the bisect_results directory to the right place. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/bad_config.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect_staging/api.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/api.py b/scripts/slave/recipe_modules/auto_bisect_staging/api.py
index 31d0529efe5f6c8989ba80e584c3428720d41aa4..961d522b6fcead720825991fea208ed8e63ea156 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/api.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/api.py
@@ -174,10 +174,6 @@ class AutoBisectStagingApi(recipe_api.RecipeApi):
This is for the merged director/tester flow.
"""
- with self.m.step.nest('Clearing results directory'):
- results_dir = self.m.path['bisect_results']
- self.m.file.rmtree('old results directory', results_dir)
- self.m.file.makedirs('new results directory', results_dir)
if self.m.platform.is_win:
self.m.chromium.taskkill()
@@ -375,6 +371,10 @@ class AutoBisectStagingApi(recipe_api.RecipeApi):
# test by checking for the presence of the good_revision key.
if api.properties.get('bisect_config').get('good_revision'):
api.step('***BISECT***', [])
+ with api.m.step.nest('Clearing results directory'):
+ results_dir = self.m.path['bisect_results']
+ self.m.file.rmtree('old results directory', results_dir)
+ self.m.file.makedirs('new results directory', results_dir)
local_bisect.perform_bisect(self, **flags)
else:
api.step('***SINGLE TEST (deprecated)***', [])
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/bad_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698