Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: components/sync/test/engine/fake_model_worker.h

Issue 2489433002: [Sync] Move thread checking into the ModelSafeWorker interface. (Closed)
Patch Set: Improve/add comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/test/engine/fake_model_worker.h
diff --git a/components/sync/test/engine/fake_model_worker.h b/components/sync/test/engine/fake_model_worker.h
index 3e5445c11e3050431df07b30a9cf234ff3dac3a2..55ab4a9e9b212d093a1fa125607fd7c0d9b0586b 100644
--- a/components/sync/test/engine/fake_model_worker.h
+++ b/components/sync/test/engine/fake_model_worker.h
@@ -6,7 +6,7 @@
#define COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_
#include "base/macros.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/threading/thread_checker.h"
#include "components/sync/base/syncer_error.h"
#include "components/sync/engine/model_safe_worker.h"
@@ -14,12 +14,13 @@ namespace syncer {
// Fake implementation of ModelSafeWorker that does work on the
// current thread regardless of the group.
-class FakeModelWorker : public ModelSafeWorker, public base::NonThreadSafe {
+class FakeModelWorker : public ModelSafeWorker {
public:
explicit FakeModelWorker(ModelSafeGroup group);
// ModelSafeWorker implementation.
ModelSafeGroup GetModelSafeGroup() override;
+ bool IsOnModelThread() override;
protected:
SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override;
@@ -28,6 +29,7 @@ class FakeModelWorker : public ModelSafeWorker, public base::NonThreadSafe {
~FakeModelWorker() override;
const ModelSafeGroup group_;
+ base::ThreadChecker thread_checker_;
DISALLOW_COPY_AND_ASSIGN(FakeModelWorker);
};

Powered by Google App Engine
This is Rietveld 408576698