Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: components/sync/test/engine/fake_model_worker.h

Issue 2489433002: [Sync] Move thread checking into the ModelSafeWorker interface. (Closed)
Patch Set: Improve/add comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_ 5 #ifndef COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_
6 #define COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_ 6 #define COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/threading/non_thread_safe.h" 9 #include "base/threading/thread_checker.h"
10 #include "components/sync/base/syncer_error.h" 10 #include "components/sync/base/syncer_error.h"
11 #include "components/sync/engine/model_safe_worker.h" 11 #include "components/sync/engine/model_safe_worker.h"
12 12
13 namespace syncer { 13 namespace syncer {
14 14
15 // Fake implementation of ModelSafeWorker that does work on the 15 // Fake implementation of ModelSafeWorker that does work on the
16 // current thread regardless of the group. 16 // current thread regardless of the group.
17 class FakeModelWorker : public ModelSafeWorker, public base::NonThreadSafe { 17 class FakeModelWorker : public ModelSafeWorker {
18 public: 18 public:
19 explicit FakeModelWorker(ModelSafeGroup group); 19 explicit FakeModelWorker(ModelSafeGroup group);
20 20
21 // ModelSafeWorker implementation. 21 // ModelSafeWorker implementation.
22 ModelSafeGroup GetModelSafeGroup() override; 22 ModelSafeGroup GetModelSafeGroup() override;
23 bool IsOnModelThread() override;
23 24
24 protected: 25 protected:
25 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override; 26 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override;
26 27
27 private: 28 private:
28 ~FakeModelWorker() override; 29 ~FakeModelWorker() override;
29 30
30 const ModelSafeGroup group_; 31 const ModelSafeGroup group_;
32 base::ThreadChecker thread_checker_;
31 33
32 DISALLOW_COPY_AND_ASSIGN(FakeModelWorker); 34 DISALLOW_COPY_AND_ASSIGN(FakeModelWorker);
33 }; 35 };
34 36
35 } // namespace syncer 37 } // namespace syncer
36 38
37 #endif // COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_ 39 #endif // COMPONENTS_SYNC_TEST_ENGINE_FAKE_MODEL_WORKER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698