Use new download notification strings

Use new download notification strings

This CL adds new download notification strings:
[scheduled] - Download pending...
[In progress] - Downloading...
[Interrupted connection] - Download waiting...
[complete] - Download complete

BUG=658744
Committed: https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d
Cr-Commit-Position: refs/heads/master@{#431462}

[qinmin, 2016-11-09 22:59:15]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org, fgorski@chromium.org

[qinmin, 2016-11-09 22:59:16]

PTAL

[dewittj, 2016-11-09 23:05:24]

drive-by comment

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1627: <message
name="IDS_DOWNLOAD_NOTIFICATION_PENDING" desc="Download notification to be
displayed when a download is pending.">
The translators may not know what "pending" means in this context, we could give
them some help with more information.  "when a download is pending - meaning the
download has been accepted but we are not yet fetching the request from the
network"

[gone, 2016-11-10 00:17:22]

lgtm overall.  Can land this while waiting for UX to answer the question on the
bug.

[fgorski, 2016-11-10 18:39:16]

fgorski@chromium.org changed reviewers:
+ dougarnett@chromium.org

[fgorski, 2016-11-10 18:39:16]

lgtm

Adding Doug who is working on properly wiring the backend of this notification.

[qinmin, 2016-11-10 19:07:25]

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1627: <message
name="IDS_DOWNLOAD_NOTIFICATION_PENDING" desc="Download notification to be
displayed when a download is pending.">
On 2016/11/09 23:05:24, dewittj wrote:
> The translators may not know what "pending" means in this context, we could
give
> them some help with more information.  "when a download is pending - meaning
the
> download has been accepted but we are not yet fetching the request from the
> network"

Done.

[qinmin, 2016-11-10 19:07:25]

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2489143002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1627: <message
name="IDS_DOWNLOAD_NOTIFICATION_PENDING" desc="Download notification to be
displayed when a download is pending.">
On 2016/11/09 23:05:24, dewittj wrote:
> The translators may not know what "pending" means in this context, we could
give
> them some help with more information.  "when a download is pending - meaning
the
> download has been accepted but we are not yet fetching the request from the
> network"

Done.

[dougarnett, 2016-11-10 19:53:46]

lgtm

[qinmin, 2016-11-11 00:37:49]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-11-11 00:37:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, fgorski@chromium.org, dougarnett@chromium.org
Link to the patchset: https://codereview.chromium.org/2489143002/#ps40001
(title: "merge waiting and pending state")

[commit-bot: I haz the power, 2016-11-11 00:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 02:08:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 02:14:31]

Description was changed from

==========
Use new download notification strings

This CL adds new download notification strings:
[scheduled] - Download pending...
[In progress] - Downloading...
[Interrupted connection] - Download waiting...
[complete] - Download complete

BUG=658744
==========

to

==========
Use new download notification strings

This CL adds new download notification strings:
[scheduled] - Download pending...
[In progress] - Downloading...
[Interrupted connection] - Download waiting...
[complete] - Download complete

BUG=658744

Committed: https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d
Cr-Commit-Position: refs/heads/master@{#431462}
==========

[commit-bot: I haz the power, 2016-11-11 02:14:32]

Patchset 3 (id:??) landed as
https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d
Cr-Commit-Position: refs/heads/master@{#431462}

[dougarnett, 2016-11-23 19:00:09]

https://codereview.chromium.org/2489143002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
(right):

https://codereview.chromium.org/2489143002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java:81:
int percentage = isOfflining ? 0 : -1;
Min, I wonder if passing isOffling (or isPending (!isOfflining)) more directly
than coercing into percentage value would be better for getting the UX right.