Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 24891002: Initial WebUI extension for enhanced bookmarks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use build-time flag to enable Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_handler.cc
diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc
index d05ee1333c40f7b8c578215ca40c9d6cb27deac5..226146cf3c72e61ca0027fa01acdfea953b598eb 100644
--- a/chrome/common/extensions/manifest_url_handler.cc
+++ b/chrome/common/extensions/manifest_url_handler.cc
@@ -276,6 +276,9 @@ bool URLOverridesHandler::Parse(Extension* extension, string16* error) {
// Restrict override pages to a list of supported URLs.
bool is_override = (page != chrome::kChromeUINewTabHost &&
page != chrome::kChromeUIBookmarksHost &&
+#if defined(ENABLE_ENHANCED_BOOKMARKS)
+ page != chrome::kChromeUIEnhancedBookmarksHost &&
+#endif
not at google - send to devlin 2013/10/01 00:21:01 so you're going to prevent extensions from overrid
Mike Wittman 2013/10/01 17:56:06 Yes, added a check so that only component extensio
page != chrome::kChromeUIHistoryHost);
#if defined(OS_CHROMEOS)
is_override = (is_override &&

Powered by Google App Engine
This is Rietveld 408576698