Initial WebUI extension for enhanced bookmarks

chrome/common/extensions/manifest_url_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest_url_handler.h"
 
 #include "base/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
@@ skipping 258 matching lines @@
   }
   scoped_ptr<URLOverrides> url_overrides(new URLOverrides);
   // Validate that the overrides are all strings
   for (base::DictionaryValue::Iterator iter(*overrides); !iter.IsAtEnd();
          iter.Advance()) {
     std::string page = iter.key();
     std::string val;
     // Restrict override pages to a list of supported URLs.
     bool is_override = (page != chrome::kChromeUINewTabHost &&
                         page != chrome::kChromeUIBookmarksHost &&
+#if defined(ENABLE_ENHANCED_BOOKMARKS)
+                        page != chrome::kChromeUIEnhancedBookmarksHost &&
+#endif

[not at google - send to devlin, 2013/10/01 00:21:01]

so you're going to prevent extensions from overriding this?

[Mike Wittman, 2013/10/01 17:56:06]

Yes, added a check so that only component extensions can override this URL and
moved the logic down with the other #if defined.. blocks.

                         page != chrome::kChromeUIHistoryHost);
 #if defined(OS_CHROMEOS)
     is_override = (is_override &&
                    page != chrome::kChromeUIActivationMessageHost);
 #endif
 #if defined(FILE_MANAGER_EXTENSION)
     is_override = (is_override &&
                    !(extension->location() == Manifest::COMPONENT &&
                      page == chrome::kChromeUIFileManagerHost));
 #endif
@@ skipping 31 matching lines @@
   extension->SetManifestData(keys::kChromeURLOverrides,
                              url_overrides.release());
   return true;
 }
 
 const std::vector<std::string> URLOverridesHandler::Keys() const {
   return SingleKey(keys::kChromeURLOverrides);
 }
 
 }  // namespace extensions