Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2489033002: content/blimp: Remove unused compositing mode switches. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, bgoldman+watch-blimp_chromium.org, jam, nasko+codewatch_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, piman+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/blimp: Remove unused compositing mode switches. Removing the unnecessary switches/code since the updated code path is used by default. This removes the content and blimp side of the code. The next patch will remove code in cc. BUG=648442 Committed: https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb Cr-Commit-Position: refs/heads/master@{#430996}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -202 lines) Patch
M blimp/client/core/compositor/blimp_compositor.h View 6 chunks +2 lines, -36 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 12 chunks +5 lines, -113 lines 0 comments Download
M blimp/client/core/context/blimp_client_context_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M blimp/client/core/render_widget/blimp_document.cc View 1 chunk +1 line, -5 lines 0 comments Download
M blimp/client/core/switches/blimp_client_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/core/switches/blimp_client_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/test/compositor/blimp_compositor_with_fake_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/app/blimp_engine_config.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +17 lines, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Khushal
4 years, 1 month ago (2016-11-09 17:58:34 UTC) #4
piman
lgtm
4 years, 1 month ago (2016-11-09 18:00:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489033002/20001
4 years, 1 month ago (2016-11-09 18:58:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 19:07:57 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 19:17:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb
Cr-Commit-Position: refs/heads/master@{#430996}

Powered by Google App Engine
This is Rietveld 408576698