Extend V8ValueConverter::Strategy for the needs of Gin Java Bridge

content/public/renderer/v8_value_converter.h

Index: content/public/renderer/v8_value_converter.h
diff --git a/content/public/renderer/v8_value_converter.h b/content/public/renderer/v8_value_converter.h
index cac1247bdd930cf6c02ba74a29af13ee43ea11e9..8891f623c044e831a8833a5452740237a289d8e4 100644
--- a/content/public/renderer/v8_value_converter.h
+++ b/content/public/renderer/v8_value_converter.h
@@ -50,6 +50,22 @@ class CONTENT_EXPORT V8ValueConverter {
                              base::Value** out,
                              v8::Isolate* isolate,
                              const FromV8ValueCallback& callback) const = 0;
+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior. v8::Object is passed as ArrayBuffer and ArrayBufferView
+    // classes are siblings.
+    virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
+                                   base::Value** out) const = 0;

[jochen (gone - plz use gerrit), 2014/04/23 15:17:33]

what about providing a default implementation that just returns false, so you
don't have to touch all concrete implementations?

[mnaganov (inactive), 2014/04/23 15:23:12]

Are you suggesting making the Strategy class non-abstract with method
implementations that return false, or still having Strategy as an interface, but
adding an implementation class to be inherited from?

+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior. This allows to intercept "non-finite" values and do something
+    // with them.
+    virtual bool FromV8Number(v8::Handle<v8::Number> value,
+                              base::Value** out) const = 0;
+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior.
+    virtual bool FromV8Undefined(base::Value** out) const = 0;
   };
 
   static V8ValueConverter* create();