Extend V8ValueConverter::Strategy for the needs of Gin Java Bridge

content/public/renderer/v8_value_converter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_
 #define CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_
 
 #include "base/callback.h"
 #include "content/common/content_export.h"
 #include "v8/include/v8.h"
@@ skipping 32 matching lines @@
                               const FromV8ValueCallback& callback) const = 0;
 
     // If false is returned, V8ValueConverter proceeds with the default
     // behavior.
     // Use |callback| to convert any child values, as this will retain
     // the ValueConverter's internal checks for depth and cycles.
     virtual bool FromV8Array(v8::Handle<v8::Array> value,
                              base::Value** out,
                              v8::Isolate* isolate,
                              const FromV8ValueCallback& callback) const = 0;
+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior. v8::Object is passed as ArrayBuffer and ArrayBufferView
+    // classes are siblings.
+    virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
+                                   base::Value** out) const = 0;

[jochen (gone - plz use gerrit), 2014/04/23 15:17:33]

what about providing a default implementation that just returns false, so you
don't have to touch all concrete implementations?

[mnaganov (inactive), 2014/04/23 15:23:12]

Are you suggesting making the Strategy class non-abstract with method
implementations that return false, or still having Strategy as an interface, but
adding an implementation class to be inherited from?

+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior. This allows to intercept "non-finite" values and do something
+    // with them.
+    virtual bool FromV8Number(v8::Handle<v8::Number> value,
+                              base::Value** out) const = 0;
+
+    // If false is returned, V8ValueConverter proceeds with the default
+    // behavior.
+    virtual bool FromV8Undefined(base::Value** out) const = 0;
   };
 
   static V8ValueConverter* create();
 
   virtual ~V8ValueConverter() {}
 
   // If true, Date objects are converted into DoubleValues with the number of
   // seconds since Unix epoch.
   //
   // Otherwise they are converted into DictionaryValues with whatever additional
@@ skipping 38 matching lines @@
   // Likewise, if an object throws while converting a property it will not be
   // converted, whereas if an array throws while converting an item it will be
   // converted to Value(TYPE_NULL).
   virtual base::Value* FromV8Value(v8::Handle<v8::Value> value,
                                    v8::Handle<v8::Context> context) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_V8_VALUE_CONVERTER_H_