Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 248883004: drive: Use test_util::SetUpTestEntries in FakeDriveServiceTest (Closed)

Created:
6 years, 8 months ago by hashimoto
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Use test_util::SetUpTestEntries in FakeDriveServiceTest Use SetUpTestEntries in tests to replace root_feed.json. Fix FakeDriveServiceTest.InitiateUpload_ExistingFile and ResumeUpload_ExistingFile. Set a default value to FakeDriveService::share_url_base_ to satisfy FakeDriveServiceTest.GetShareURL. BUG=334544 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -168 lines) Patch
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 85 chunks +102 lines, -167 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hashimoto
6 years, 8 months ago (2014-04-24 03:03:54 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-24 03:52:31 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-24 03:54:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/248883004/1
6 years, 8 months ago (2014-04-24 03:55:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 05:18:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 05:18:37 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-24 05:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/248883004/1
6 years, 8 months ago (2014-04-24 05:28:27 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 05:36:30 UTC) #9
Message was sent while issue was closed.
Change committed as 265865

Powered by Google App Engine
This is Rietveld 408576698