third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html - Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'. (Closed)

Patch Set: Addressed comments (@alexmos #2) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/ancestor_throttle.cc ('K') | « third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

index 82a05e0c172c7b2a376df2eb847c8dd7973959e6..b226aa8df62d0eb1d6cb58dd2bfa8141bc2d660b 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

@@ -36,8 +36,10 @@ function test()

function loadingFailed(requestId, time, localizedDescription, canceled)

{

var request = InspectorTest.networkLog.requestForId(requestId);

- if (/x-frame-options-deny\.cgi/.exec(request.url))

+ if (/x-frame-options-deny\.cgi/.exec(request.url)) {

+ InspectorTest.addResult("TODO(mkwst): This started failing when we moved XFO to the browser.");

InspectorTest.completeTest();

+ }

}

</script>