third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html - Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

Issue 2488743003: (Re-)introduce AncestorThrottle to handle 'X-Frame-Options'. (Closed)

Patch Set: Addressed comments (@alexmos #2) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/frame_host/ancestor_throttle.cc ('K') | « third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script>	4 <script>

5 function loadIFrameWithDownload()	5 function loadIFrameWithDownload()

6 {	6 {

7 var iframe = document.createElement("iframe");	7 var iframe = document.createElement("iframe");

8 iframe.setAttribute("src", "http://127.0.0.1:8000/security/XFrameOptions/res ources/x-frame-options-deny.cgi");	8 iframe.setAttribute("src", "http://127.0.0.1:8000/security/XFrameOptions/res ources/x-frame-options-deny.cgi");

9 document.body.appendChild(iframe);	9 document.body.appendChild(iframe);

10 }	10 }

(...skipping 18 matching lines...) Expand all Loading...
29 function loadingFinished(requestId, finishTime)	29 function loadingFinished(requestId, finishTime)

30 {	30 {

31 var request = InspectorTest.networkLog.requestForId(requestId);	31 var request = InspectorTest.networkLog.requestForId(requestId);

32 if (/x-frame-options-deny\.cgi/.exec(request.url))	32 if (/x-frame-options-deny\.cgi/.exec(request.url))

33 InspectorTest.completeTest();	33 InspectorTest.completeTest();

34 }	34 }

35	35

36 function loadingFailed(requestId, time, localizedDescription, canceled)	36 function loadingFailed(requestId, time, localizedDescription, canceled)

37 {	37 {

38 var request = InspectorTest.networkLog.requestForId(requestId);	38 var request = InspectorTest.networkLog.requestForId(requestId);

39 if (/x-frame-options-deny\.cgi/.exec(request.url))	39 if (/x-frame-options-deny\.cgi/.exec(request.url)) {

	40 InspectorTest.addResult("TODO(mkwst): This started failing when we m oved XFO to the browser.");

40 InspectorTest.completeTest();	41 InspectorTest.completeTest();

	42 }

41 }	43 }

42 }	44 }

43 </script>	45 </script>

44 </head>	46 </head>

45 <body onload="runTest()">	47 <body onload="runTest()">

46 <p>Tests that responseReceived is called on NetworkDispatcher for resource reque sts denied due to X-Frame-Options header.</p>	48 <p>Tests that responseReceived is called on NetworkDispatcher for resource reque sts denied due to X-Frame-Options header.</p>

47 </body>	49 </body>

48 </html>	50 </html>

OLD	NEW