Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2488703003: Remove SVGViewElement.viewTarget attribute (Closed)

Created:
4 years, 1 month ago by Shanmuga Pandi
Modified:
4 years, 1 month ago
Reviewers:
fs, timvolodine, foolip
CC:
fs, android-webview-reviews_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGViewElement.viewTarget attribute As per SVG2.0, SVGViewElement.viewTarget is removed. https://github.com/w3c/svgwg/commit/c1690ae1b99aa95c648a304ec7a8f7dec46d7c83 Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X3kyDbj9xlA BUG=633908 Committed: https://crrev.com/335c071421e78b900d0108a7fa6e621fb2b9d941 Cr-Commit-Position: refs/heads/master@{#432144}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebased and align with comments #

Patch Set 3 : nits #

Patch Set 4 : fixed layout test failures in html5lib #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -55 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/html5lib/resources/tests11.dat View 1 2 3 5 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAttributeNames.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.cpp View 1 2 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
Shanmuga Pandi
PTAL!!
4 years, 1 month ago (2016-11-09 13:58:38 UTC) #2
fs
lgtm https://codereview.chromium.org/2488703003/diff/1/third_party/WebKit/Source/core/svg/SVGViewElement.cpp File third_party/WebKit/Source/core/svg/SVGViewElement.cpp (right): https://codereview.chromium.org/2488703003/diff/1/third_party/WebKit/Source/core/svg/SVGViewElement.cpp#newcode25 third_party/WebKit/Source/core/svg/SVGViewElement.cpp:25: #include "core/svg/SVGStaticStringList.h" Nit: Looks unused. https://codereview.chromium.org/2488703003/diff/1/third_party/WebKit/Source/core/svg/SVGViewElement.h File third_party/WebKit/Source/core/svg/SVGViewElement.h ...
4 years, 1 month ago (2016-11-09 14:35:01 UTC) #3
foolip
LGTM % nit https://github.com/w3c/web-platform-tests/blob/master/svg/historical.html should also test that this is removed, I'll send a PR. ...
4 years, 1 month ago (2016-11-09 15:08:58 UTC) #4
foolip
Sent https://github.com/w3c/web-platform-tests/pull/4188
4 years, 1 month ago (2016-11-09 15:13:37 UTC) #5
Shanmuga Pandi
timvolodine@chromium.org: Please review changes in android_webview
4 years, 1 month ago (2016-11-11 10:14:17 UTC) #7
timvolodine
On 2016/11/11 10:14:17, Shanmuga Pandi wrote: > mailto:timvolodine@chromium.org: Please review changes in android_webview android_webview/.. -- ...
4 years, 1 month ago (2016-11-11 15:00:23 UTC) #8
Shanmuga Pandi
https://codereview.chromium.org/2488703003/diff/1/third_party/WebKit/Source/core/svg/SVGViewElement.cpp File third_party/WebKit/Source/core/svg/SVGViewElement.cpp (left): https://codereview.chromium.org/2488703003/diff/1/third_party/WebKit/Source/core/svg/SVGViewElement.cpp#oldcode33 third_party/WebKit/Source/core/svg/SVGViewElement.cpp:33: SVGStaticStringList::create(this, SVGNames::viewTargetAttr)) { On 2016/11/09 15:08:58, foolip wrote: > ...
4 years, 1 month ago (2016-11-15 04:19:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488703003/20001
4 years, 1 month ago (2016-11-15 04:21:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/304102)
4 years, 1 month ago (2016-11-15 04:43:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488703003/40001
4 years, 1 month ago (2016-11-15 05:04:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488703003/60001
4 years, 1 month ago (2016-11-15 06:36:45 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 08:20:53 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 08:22:51 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/335c071421e78b900d0108a7fa6e621fb2b9d941
Cr-Commit-Position: refs/heads/master@{#432144}

Powered by Google App Engine
This is Rietveld 408576698