Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGViewElement.cpp

Issue 2488703003: Remove SVGViewElement.viewTarget attribute (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #include "core/svg/SVGViewElement.h" 21 #include "core/svg/SVGViewElement.h"
22 22
23 #include "core/SVGNames.h" 23 #include "core/SVGNames.h"
24 #include "core/frame/UseCounter.h" 24 #include "core/frame/UseCounter.h"
25 #include "core/svg/SVGStaticStringList.h" 25 #include "core/svg/SVGStaticStringList.h"
fs 2016/11/09 14:35:01 Nit: Looks unused.
Shanmuga Pandi 2016/11/15 04:19:58 Done.
26 26
27 namespace blink { 27 namespace blink {
28 28
29 inline SVGViewElement::SVGViewElement(Document& document) 29 inline SVGViewElement::SVGViewElement(Document& document)
30 : SVGElement(SVGNames::viewTag, document), 30 : SVGElement(SVGNames::viewTag, document),
31 SVGFitToViewBox(this), 31 SVGFitToViewBox(this) {
32 m_viewTarget(
33 SVGStaticStringList::create(this, SVGNames::viewTargetAttr)) {
foolip 2016/11/09 15:08:58 With this gone you can also drop viewTarget from S
Shanmuga Pandi 2016/11/15 04:19:58 Done.
34 addToPropertyMap(m_viewTarget);
35 UseCounter::count(document, UseCounter::SVGViewElement); 32 UseCounter::count(document, UseCounter::SVGViewElement);
36 } 33 }
37 34
38 DEFINE_NODE_FACTORY(SVGViewElement) 35 DEFINE_NODE_FACTORY(SVGViewElement)
39 36
40 DEFINE_TRACE(SVGViewElement) { 37 DEFINE_TRACE(SVGViewElement) {
41 visitor->trace(m_viewTarget);
42 SVGElement::trace(visitor); 38 SVGElement::trace(visitor);
43 SVGFitToViewBox::trace(visitor); 39 SVGFitToViewBox::trace(visitor);
44 } 40 }
45 41
46 SVGStringListTearOff* SVGViewElement::viewTarget() {
47 return m_viewTarget->tearOff();
48 }
49
50 void SVGViewElement::parseAttribute(const QualifiedName& name, 42 void SVGViewElement::parseAttribute(const QualifiedName& name,
51 const AtomicString& oldValue, 43 const AtomicString& oldValue,
52 const AtomicString& value) { 44 const AtomicString& value) {
53 if (SVGZoomAndPan::parseAttribute(name, value)) 45 if (SVGZoomAndPan::parseAttribute(name, value))
54 return; 46 return;
55 47
56 SVGElement::parseAttribute(name, oldValue, value); 48 SVGElement::parseAttribute(name, oldValue, value);
57 } 49 }
58 50
59 } // namespace blink 51 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698