Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2488673003: Ozone DRM: Improve inclusions of hardcoded definitions for dma-buf. (Closed)

Created:
4 years, 1 month ago by fwang
Modified:
4 years, 1 month ago
Reviewers:
rjkroege, tonikitoo
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone DRM: Improve inclusions of hardcoded definitions for dma-buf. The USE_OZONE conditional to include hardcoded definitions for dma-buf is removed from client_native_pixmap_dmabuf.cc since this file is only built on Ozone anyway. We also just include linux/dma-buf.h for version 4.6.0 or higher. BUG=None Committed: https://crrev.com/743c066bdf98ba50752ea2cb135ded25292b142f Cr-Commit-Position: refs/heads/master@{#430723}

Patch Set 1 #

Patch Set 2 : Use correct version of Linux. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fwang
I'm not sure about the linux/dma-buf.h part... On my system (Debian) the file is not ...
4 years, 1 month ago (2016-11-08 15:54:59 UTC) #3
tonikitoo
non-owner lgtm. IMO, this is a progression since it replaces a redundant USE_OZONE check by ...
4 years, 1 month ago (2016-11-08 16:00:31 UTC) #5
rjkroege
lgtm
4 years, 1 month ago (2016-11-08 20:08:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488673003/20001
4 years, 1 month ago (2016-11-08 20:53:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 21:39:25 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:46:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/743c066bdf98ba50752ea2cb135ded25292b142f
Cr-Commit-Position: refs/heads/master@{#430723}

Powered by Google App Engine
This is Rietveld 408576698